-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytorch 1.12.1 - and Disable kineto due to cupti conflict #136
Pytorch 1.12.1 - and Disable kineto due to cupti conflict #136
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2022.07.31.08.11.05
This isn't having the desired effect, the 10.2 build shows:
|
recipe/build_pytorch.sh
Outdated
# CUPTI seems to cause trouble when users install a version of | ||
# cudatoolkit different than the one specified at compile time. | ||
# https://github.com/conda-forge/pytorch-cpu-feedstock/issues/135 | ||
export LIBKINETO_NOCUPTI=ON | ||
export USE_KINETO=ON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget to set it to "OFF" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Suggestion: limit the builds to cuda112 and only use one cuda arch (e.g. 8.0) for testing here so that the ci finishes within six hours |
Seems like that would complicate the process even more. I would rather do one thing at once. address the cupti bugs instead of revamping the build system at the same time. |
Fine with me. My suggestions was merely to get this to finish within six hours for diagnostics only within this PR, not a permanent change. So once we see if disabling kineto actually does the trick, we can go back to build all the cuda arches as before. This would remove the need to build this locally (unless you got the info below from the CI?)
|
The 10.2 builds finish within the allotted time (sometimes) so you can check those. That is what I did in what you quoted. |
Ah, didn't know that. Okay then, we can check that in the meanwhile! |
Well kineto is properly disabled, and |
Let's try to change this into 1.12.1? |
I guess i had the builds ready, but I don't see a sense in having too much uploaded. |
If you do, just upload them! Sorry I only wrote that thinking you haven't built them already! Upload them and we can deal with the 1.12.1 stuff later |
Also, I am not sure if this is their final 1.12.1 tag... pytorch/pytorch@v1.12.0...v1.12.1 They didn't announce it under releases, but it has already appeared on pypi, etc. |
I'm pretty swamped right now with the day job.i think i can get this in by next week |
Take your time :) |
GPU build logs |
GPU builds are being uploaded now. |
Hi! This is the friendly automated conda-forge-webservice.
I've rerendered the recipe as instructed in #135.
Here's a checklist to do before merging.