Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the recipe for Simbody 3.6. #21

Closed
wants to merge 6 commits into from

Conversation

moorepants
Copy link
Contributor

@moorepants moorepants commented Feb 21, 2018

  • Investigate if we can use the conda forge packages: xorg-libxi and xorg-libxmu.
  • Simbody 3.6 seems to require GCC 4.9, is this available in the conda-forge tool chain?
  • Add the docs? doxygen is available in conda-forge.
  • Are we building with at least lapack 3.6? Seems like Opensim will require this.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@moorepants
Copy link
Contributor Author

@conda-forge-admin rerender

@moorepants
Copy link
Contributor Author

@conda-forge-admin, please rerender

@moorepants
Copy link
Contributor Author

@conda-forge-admin, please update circle

recipe/meta.yaml Outdated

build:
number: 205
number: 201
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still correct to set this build number to this high value instead of 0?

@moorepants
Copy link
Contributor Author

@conda-forge-admin, please update circle

@isuruf
Copy link
Member

isuruf commented Feb 21, 2018

It seems the error is in the circle-ci project of your fork. Can you unfollow your fork and push an empty commit?

@moorepants
Copy link
Contributor Author

What do you mean by "unfollow"?

@moorepants
Copy link
Contributor Author

C++ compile error on Mac:

[  1%] Building CXX object SimTKcommon/sharedTarget/CMakeFiles/SimTKcommon.dir/__/src/ParallelExecutor.cpp.o
In file included from /Users/travis/miniconda3/conda-bld/simbody_1519252775835/work/simbody-Simbody-3.6/SimTKcommon/src/ParallelExecutor.cpp:24:
/Users/travis/miniconda3/conda-bld/simbody_1519252775835/work/simbody-Simbody-3.6/SimTKcommon/src/ParallelExecutorImpl.h:85:12: error: thread-local storage is not supported for the current target
    static thread_local bool isWorker;
           ^
/Users/travis/miniconda3/conda-bld/simbody_1519252775835/work/simbody-Simbody-3.6/SimTKcommon/src/ParallelExecutor.cpp:123:1: error: thread-local storage is not supported for the current target
thread_local bool ParallelExecutorImpl::isWorker(false);
^
2 errors generated.
make[2]: *** [SimTKcommon/sharedTarget/CMakeFiles/SimTKcommon.dir/__/src/ParallelExecutor.cpp.o] Error 1

@isuruf
Copy link
Member

isuruf commented Feb 21, 2018

https://circleci.com/docs/1.0/getting-started/#add-and-follow-more-projects

C++ compile error is because clang compiler by apple has thread local storage disabled. This will be fixed in the anaconda compilers, but you'll have to wait till conda-build=3 update to conda-forge

@moorepants
Copy link
Contributor Author

I unfollowed and pushed an empty commit.

@isuruf
Copy link
Member

isuruf commented Feb 21, 2018

Do you see a "Stop Building" button in https://circleci.com/gh/moorepants/simbody-feedstock/edit ?

@moorepants
Copy link
Contributor Author

Yes, push it?

@isuruf
Copy link
Member

isuruf commented Feb 21, 2018

Yes

@moorepants
Copy link
Contributor Author

Ok, pushed.

@isuruf
Copy link
Member

isuruf commented Feb 21, 2018

Need another empty commit

@moorepants
Copy link
Contributor Author

C++ compile error is because clang compiler by apple has thread local storage disabled. This will be fixed in the anaconda compilers, but you'll have to wait till conda-build=3 update to conda-forge

So, best thing is to disable Mac builds for this version of Simbody?

@isuruf
Copy link
Member

isuruf commented Feb 21, 2018

You can try adding clangdev as a build requirement. It might work.

@moorepants
Copy link
Contributor Author

Is there a standard procedure for using gcc 4.9?

@isuruf
Copy link
Member

isuruf commented Feb 21, 2018

Not yet. You'll have to wait till conda-build=3 update to conda-forge which gives you gcc 7.2

@moorepants
Copy link
Contributor Author

Ok, looks like I'll just have to put this on hold till conda build 3. Thanks for the help.

@chrisdembia chrisdembia mentioned this pull request Oct 30, 2018
4 tasks
@moorepants
Copy link
Contributor Author

Close in favor of #23.

@moorepants moorepants closed this Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants