Create new version 3.6.1 #23

chrisdembia · 2018-10-30T21:29:18Z

Checklist

Used a fork of the feedstock to propose changes
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy
Ensured the license file is being packaged.

How do I ensure a new version is created? Could you create a new branch 3.6 in conda-forge/simbody-feedstock?

conda-forge-linter · 2018-10-30T21:29:48Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter · 2018-10-30T21:31:24Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

conda-forge-linter · 2018-10-30T21:31:29Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

chrisdembia · 2018-10-30T22:17:47Z

Ah I just realized there's already #21 . This PR is running into the same problem. I've been wading through documentation for using conda-build 3 but I'm a little confused. Can you provide some help using a more recent Clang on macOS that supports thread_local?

chrisdembia · 2018-10-30T23:31:55Z

@conda-forge-admin, please update for conda-build 3

chrisdembia · 2018-10-30T23:42:56Z

@conda-forge-admin, please rerender

moorepants · 2018-10-31T02:31:23Z

recipe/meta.yaml


 build:
-    number: 206
+    number: 0


This may need to be a special number since it depends on open blas. I've been seeing 1000 for new conda 3 builds. Not quite sure why that is though.

Oh interesting... thanks.

moorepants · 2018-10-31T02:32:12Z

recipe/meta.yaml

        - {{ compiler('c') }}
        - {{ compiler('cxx') }}
+        - xorg-libxi              # [linux]
+        - xorg-libxmu             # [linux]
+        - libglu                  # [linux]


These were install by yum previously, can probably remove that yum file now. I think it is deprecated.

Okay. I can't get Simbody to find GL.h either way yet.

moorepants · 2018-10-31T02:32:55Z

Thanks. This will be cool if it works!

chrisdembia · 2018-10-31T02:36:49Z

Thanks. This will be cool if it works!

Yeah.

Sorry for not noticing your original PR.

The issue with thread_local on Mac is resolved now.

moorepants · 2018-10-31T02:37:56Z

[ 66%] Building CXX object Simbody/Visualizer/simbody-visualizer/CMakeFiles/simbody-visualizer.dir/simbody-visualizer.cpp.o
/home/conda/feedstock_root/build_artifacts/simbody_1540952477226/work/Simbody/Visualizer/simbody-visualizer/simbody-visualizer.cpp:85:14: fatal error: GL/gl.h: No such file or directory
     #include <GL/gl.h>
              ^~~~~~~~~
compilation terminated.
make[2]: *** [Simbody/Visualizer/simbody-visualizer/CMakeFiles/simbody-visualizer.dir/simbody-visualizer.cpp.o] Error 1
make[1]: *** [Simbody/Visualizer/simbody-visualizer/CMakeFiles/simbody-visualizer.dir/all] Error 2
make: *** [all] Error 2
Traceback (most recent call last):
  File "/opt/conda/bin/conda-build", line 11, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.6/site-packages/conda_build/cli/main_build.py", line 439, in main
    execute(sys.argv[1:])
  File "/opt/conda/lib/python3.6/site-packages/conda_build/cli/main_build.py", line 430, in execute
    verify=args.verify, variants=args.variants)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/api.py", line 201, in build
    notest=notest, need_source_download=need_source_download, variants=variants)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/build.py", line 2275, in build_tree
    notest=notest,
  File "/opt/conda/lib/python3.6/site-packages/conda_build/build.py", line 1500, in build
    utils.check_call_env(cmd, env=env, cwd=src_dir, stats=build_stats)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/utils.py", line 319, in check_call_env
    return _func_defaulting_env_to_os_environ('call', *popenargs, **kwargs)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/utils.py", line 299, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['/bin/bash', '-e', '/home/conda/feedstock_root/build_artifacts/simbody_1540952477226/work/conda_build.sh']' returned non-zero exit status 2.
Exited with code 1```

FYI

moorepants · 2018-10-31T02:39:08Z

Same as: simbody/simbody#511

chrisdembia · 2018-10-31T02:39:21Z

Thanks @moorepants. Did you ever get past that error with conda-forge?

moorepants · 2018-10-31T02:39:56Z

Yes, but you deleted the workaround I had in the build.sh file. :)

moorepants · 2018-10-31T02:43:49Z

Or maybe you didn't...maybe the glut headers aren't getting installed.

chrisdembia · 2018-11-01T17:08:56Z

Okay I decided to hold off on the visualizer (and doxygen) for now. I don't want those features to hold up getting the package updated. My hope is that we can iterate later on adding support for the visualizer, etc.

It would be great if we could start the review process.

chrisdembia · 2018-11-02T16:46:12Z

Let me know if there is anything I need to do to start the review process here.

@kidzik, thought you might be interested in this.

chrisdembia · 2018-11-09T21:48:53Z

@moorepants do you know how we start the review process?

moorepants · 2018-11-09T22:06:55Z

I can review. Just haven't had time. I'll see what I can do over the long weekend.

chrisdembia · 2018-11-09T23:03:41Z

Oh okay neat! It's not urgent.

recipe/meta.yaml

moorepants · 2018-11-14T19:10:04Z

recipe/build.sh

 elif [[ "$OSTYPE" == "darwin"* ]]; then
 	SKIP_TEST=()
 	GLUT_OVERRIDE=()
 fi
+
+# https://github.com/AnacondaRecipes/freeglut-feedstock/blob/master/recipe/build.sh


Maybe a note about why this is linked here.

moorepants · 2018-11-14T19:10:56Z

recipe/build.sh

 cmake .. \
 	-DCMAKE_INSTALL_PREFIX="$PREFIX" \
 	-DCMAKE_INSTALL_LIBDIR="lib" \
 	-DCMAKE_BUILD_TYPE="RELEASE" \
+    ${CMAKE_PLATFORM_FLAGS[@]} \


Match indentation?

moorepants · 2018-11-14T19:12:21Z

recipe/cross-linux.cmake

@@ -0,0 +1,18 @@
+# https://github.com/ContinuumIO/anaconda-issues/issues/8779
+# https://github.com/AnacondaRecipes/freeglut-feedstock/blob/master/recipe/cross-linux.cmake
+# this one is important


These notes could be a bit more informative.

moorepants · 2018-11-14T19:13:31Z

This looks fine. I just hope that we can get the visualizer going in linux ASAP.

moorepants · 2018-11-14T19:16:09Z

Do we need to be using this: https://conda-forge.org/docs/meta.html#using-conda-build-s-run-exports-feature ? We are producing a shared library that other people will link against.

chrisdembia · 2018-11-16T06:34:53Z

Do we need to be using this: https://conda-forge.org/docs/meta.html#using-conda-build-s-run-exports-feature ? We are producing a shared library that other people will link against.

Ah thanks. I've attempted to add this.

Ready for review again.

moorepants · 2018-11-16T15:52:46Z

recipe/meta.yaml

        - {{ compiler('c') }}
        - {{ compiler('cxx') }}
+          # - doxygen                 # [not linux]


moorepants · 2018-11-16T15:58:10Z

recipe/meta.yaml

-    number: 206
+    number: 1001
+    run_exports:
+        - {{ pin_subpackage('simbody', max_pin='x.x') }}


I still don't quite understand this after reading the conda documentation but I guess it will only matter once someone trys to link against it in an upstream package. It can be adjusted then if needed.

My understanding isn't great either.

moorepants · 2018-11-16T16:00:24Z

I removed that one commented line. Will merge once tests pass.

chrisdembia · 2018-11-16T17:55:48Z

Thank you @moorepants!

chrisdembia · 2018-11-16T22:47:38Z

Do you know how long it should take for the updated version to be available? Locally, I'm seeing the following (no 3.6.1):

14:18 ~ /usr/local/miniconda3/bin/conda search -c conda-forge simbody
Loading channels: done
# Name                  Version           Build  Channel             
simbody                   3.5.3 blas_openblas_200  conda-forge         
simbody                   3.5.3 blas_openblas_201  conda-forge         
simbody                   3.5.4 blas_openblas_200  conda-forge         
simbody                   3.5.4 blas_openblas_201  conda-forge         
simbody                   3.5.4 blas_openblas_202  conda-forge         
simbody                   3.5.4 blas_openblas_203  conda-forge         
simbody                   3.5.4 blas_openblas_204  conda-forge         
simbody                   3.5.4 blas_openblas_205  conda-forge         
simbody                   3.5.4 blas_openblash0edd121_206  conda-forge

However, Anaconda Cloud lists 3.6.1:

https://anaconda.org/conda-forge/simbody/files

isuruf · 2018-11-16T22:51:26Z

Newer compiler builds are uploaded to conda-forge/label/gcc7 as they are incompatible with the main channel builds which were created with gcc4

isuruf · 2018-11-16T22:52:18Z

Once all the packages have been rebuilt with gcc7, they'll be dumped to the main channel. It'll take a few weeks for the rebuild process to finish

chrisdembia · 2018-11-16T23:13:41Z

Ah then how do I specify simbody as a dependency in another package? {{ cdt('simbody') }}?

chrisdembia and others added 3 commits October 30, 2018 14:18

3.6.1

719cf8f

Remove unnecessary GUT_OVERRIDE.

c33399d

MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.10.16

f97d6b9

Update sha256.

a94e3b5

Create conda_build_config.yaml

3d76a3f

conda-forge-admin and others added 4 commits October 30, 2018 23:32

Update for conda-build 3

6e4de8d

MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.10.16

c26c30d

Remove duplicate host.

84cbf0c

Update conda-forge.yml

6423667

conda-forge-admin and others added 5 commits October 30, 2018 23:44

MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.10.16

2de6b04

libxi libxmu libglu

9cca3a3

linux only for xorg

4c1e75b

Bring back GLUT_OVERRIDE

adf1dca

Update build.sh

e29bbdb

moorepants reviewed Oct 31, 2018

View reviewed changes

Update build.sh

a9d200b

chrisdembia added 2 commits November 1, 2018 00:56

Build doxygen only on Mac.

a51e64b

No doxygen for now.

954d565

chrisdembia mentioned this pull request Nov 1, 2018

conda's gcc can't find OpenGL conda/conda#2170

Closed

chrisdembia mentioned this pull request Nov 14, 2018

Investigate the use of python wheels for python wrapping opensim-org/opensim-core#486

Closed

moorepants reviewed Nov 14, 2018

View reviewed changes

recipe/meta.yaml Show resolved Hide resolved

moorepants reviewed Nov 14, 2018

View reviewed changes

moorepants mentioned this pull request Nov 14, 2018

Update the recipe for Simbody 3.6. #21

Closed

4 tasks

Address @moorepants' comments.

a6ad101

moorepants reviewed Nov 16, 2018

View reviewed changes

recipe/meta.yaml Outdated

- {{ compiler('c') }}

- {{ compiler('cxx') }}

# - doxygen # [not linux]

Copy link

Contributor

moorepants Nov 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

moorepants reviewed Nov 16, 2018

View reviewed changes

Removed commented doxygen line.

51eb0b3

moorepants merged commit a1318e0 into conda-forge:master Nov 16, 2018

moorepants mentioned this pull request Nov 16, 2018

Enable the visualizer on linux #25

Closed

chrisdembia deleted the 3.6.1 branch November 16, 2018 17:55

Create new version 3.6.1 #23

Create new version 3.6.1 #23

Conversation

chrisdembia commented Oct 30, 2018 • edited

conda-forge-linter commented Oct 30, 2018

conda-forge-linter commented Oct 30, 2018

conda-forge-linter commented Oct 30, 2018

chrisdembia commented Oct 30, 2018

chrisdembia commented Oct 30, 2018

chrisdembia commented Oct 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moorepants commented Oct 31, 2018

chrisdembia commented Oct 31, 2018

moorepants commented Oct 31, 2018

moorepants commented Oct 31, 2018

chrisdembia commented Oct 31, 2018

moorepants commented Oct 31, 2018

moorepants commented Oct 31, 2018

chrisdembia commented Nov 1, 2018

chrisdembia commented Nov 2, 2018

chrisdembia commented Nov 9, 2018

moorepants commented Nov 9, 2018

chrisdembia commented Nov 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moorepants commented Nov 14, 2018

moorepants commented Nov 14, 2018

chrisdembia commented Nov 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moorepants commented Nov 16, 2018

chrisdembia commented Nov 16, 2018

chrisdembia commented Nov 16, 2018

isuruf commented Nov 16, 2018

isuruf commented Nov 16, 2018

chrisdembia commented Nov 16, 2018

chrisdembia commented Oct 30, 2018 •

edited