Adding psrchive

[demorest]

Checklist

• Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
• License file is packaged (see here for an example)
• Source is from official source
• Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
• If static libraries are linked in, the license of the static library is packaged.
• Build number is 0
• A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
• GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there
• When in trouble, please check our knowledge base documentation before pinging a team.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/psrchive) and found it was in an excellent condition.

[demorest]

OK, this appears to be building correctly now. If someone could review it that would be great, thanks!

[demorest]

@conda-forge/staged-recipes I think this is ready to go, could someone give it a review? Thank you!

[demorest]

OK, meta.yaml is now 2-space indented. And for completeness I added a couple more build requirements (make, perl). Anything else that should be done for this one?

[ocefpaf]

I'm not 100% sure on the syntax here. I thought it should be =. @isuruf, sorry to bother you with this but can you take a quick look?

[isuruf]

Just libcblas

[demorest]

So this was a tricky/confusing issue for me. The package does not directly depend on BLAS, only indirectly via GSL (it uses some of the gsl_blas_* functions). Here are the various things I tried and what the results were:

1. Only gsl in the requirements (ie no BLAS library explicitly mentioned). This resulted in openblas being installed during the build, and an "overlinking" error for libopenblas.
2. libcblas added to requirements. Same results as above (build used openblas, overlinking error).
3. libcblas * *netlib in the requirements (host section only). This resulted in the netlib BLAS being used successfully in the build, with no errors. The test stage used openblas with no problem.

I arrived at this final version after reading https://conda-forge.org/docs/maintainer/knowledge_base.html#blas which implied builds should use netlib, although this didn't happen until I explicitly specified it.

All the results from these various attempts can be found in the failed builds above in this PR but please let me know if there is other specific information I can provide regarding this. Suggestions on how best to solve this are certaintly welcome!

[demorest]

Hi folks, any additional thoughts on this? TL;DR version of my last post was that I tried "just libcblas" and it didn't work. Thanks!

[ocefpaf]

All the results from these various attempts can be found in the failed builds above in this PR but please let me know if there is other specific information I can provide regarding this. Suggestions on how best to solve this are certaintly welcome!

Sorry I did not checked the commit history. Did you try Isuru's suggestion and that did not work? If not, do you mind testing it so we can check?

[demorest]

Yes, I did try that and it did not work (it was "2" in my list above). But it looks like I only did that test on my local system. I'll push that change here so you guys can take a look.

[ocefpaf]

I'll push that change here so you guys can take a look.

Thanks. If there is nothing we can do to fix it we can revert and merge as-is.

[demorest]

Glad this worked, thanks again for the help! I'll have to look into why it failed for me locally, maybe different version of conda build or something like that.