Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding memo #13819

Merged
merged 3 commits into from
Jan 30, 2021
Merged

Adding memo #13819

merged 3 commits into from
Jan 30, 2021

Conversation

RoyalTS
Copy link
Contributor

@RoyalTS RoyalTS commented Jan 29, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/memo) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/memo:

  • noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

@RoyalTS
Copy link
Contributor Author

RoyalTS commented Jan 29, 2021

@koaning, can you please confirm you're willing to be listed as a maintainer?

recipes/memo/meta.yaml Outdated Show resolved Hide resolved
recipes/memo/meta.yaml Outdated Show resolved Hide resolved
@koaning
Copy link

koaning commented Jan 30, 2021

Sure!

@koaning
Copy link

koaning commented Jan 30, 2021

My name is Vincent and I confirm that I am a maintainer.

Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/memo) and found it was in an excellent condition.

Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
@xhochy xhochy merged commit 7cac870 into conda-forge:master Jan 30, 2021
@RoyalTS RoyalTS deleted the memo branch January 30, 2021 17:04
@RoyalTS RoyalTS mentioned this pull request Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants