Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding sd to the feedstock #14150

Merged
merged 3 commits into from
Jul 29, 2021
Merged

adding sd to the feedstock #14150

merged 3 commits into from
Jul 29, 2021

Conversation

ivergara
Copy link
Contributor

@ivergara ivergara commented Mar 3, 2021

Checklist

  • [x ] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [x ] License file is packaged (see here for an example).
  • [x ] Source is from official source.
  • [x ] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • [ x] Build number is 0.
  • [x ] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [ x] When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/example/sd) and found some lint.

Here's what I've got...

For recipes/example/sd:

  • Please move the recipe out of the example dir and into its own dir.
  • Please do not delete the example recipe found in recipes/example/meta.yaml.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sd) and found it was in an excellent condition.

@ivergara
Copy link
Contributor Author

ivergara commented Mar 3, 2021

@conda-forge-admin, please ping team

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

recipes/sd/meta.yaml Outdated Show resolved Hide resolved
Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't bundle the licenses of rust deps.

@xhochy
Copy link
Member

xhochy commented Mar 3, 2021

@ivergara
Copy link
Contributor Author

ivergara commented Mar 3, 2021

@isuruf is there any kind of example on how to accomplish that? Or is what @xhochy pointed out the only way? I used the recipes for bat and ripgrep as a template.

@isuruf
Copy link
Member

isuruf commented Mar 3, 2021

build:
- {{ compiler('rust') }}
- {{ compiler('c') }} # [not win]
- {{ compiler('m2w64_c') }} # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily, but checking the meta.yml file in three other packaged rust projects they all have it. I could try removing it and see if the automated tests don't fail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now changed to a copy-pasta from bat

@jonashaag jonashaag mentioned this pull request Jul 29, 2021
9 tasks
@jonashaag
Copy link
Contributor

Added Rust licenses

@xhochy
Copy link
Member

xhochy commented Jul 29, 2021

LGTM, @isuruf also fine with you?

@xhochy xhochy merged commit 847cdbd into conda-forge:master Jul 29, 2021
@ivergara ivergara deleted the sd branch July 29, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants