-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding sd to the feedstock #14150
adding sd to the feedstock #14150
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/example/sd:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please ping team |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't bundle the licenses of rust deps.
@isuruf Do we have anything better than https://github.com/conda-forge/rage-feedstock/blob/8d12868f40b85d3ce9d185ba45a1912b18175afe/recipe/build.sh#L8-L17 nowadays? |
recipes/sd/meta.yaml
Outdated
build: | ||
- {{ compiler('rust') }} | ||
- {{ compiler('c') }} # [not win] | ||
- {{ compiler('m2w64_c') }} # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily, but checking the meta.yml
file in three other packaged rust projects they all have it. I could try removing it and see if the automated tests don't fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now changed to a copy-pasta from bat
Added Rust licenses |
LGTM, @isuruf also fine with you? |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).