Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xyz2mol #17412

Merged
merged 5 commits into from
Jan 6, 2022
Merged

add xyz2mol #17412

merged 5 commits into from
Jan 6, 2022

Conversation

hadim
Copy link
Member

@hadim hadim commented Jan 5, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/xyz2mol) and found it was in an excellent condition.

@hadim
Copy link
Member Author

hadim commented Jan 5, 2022

@jhjensen2: here the recipe that will build the conda package. Once merged, a feedstock repo will be created where the package will be built and uploaded. Once the process done (after a review step from a conda forge dev), the package will be available at conda install -c conda-forge xyz2mol). For more details see the documentation at https://conda-forge.org/docs/index.html

Please explicitly confirm here you agree to be a maintainer of the package (this is mandatory before merging).

@hadim
Copy link
Member Author

hadim commented Jan 5, 2022

@conda-forge/staged-recipes please review. I am not sure to understand the windows CI error, but it might be irrelevant since the package is pure python. Let me know.

Co-authored-by: Ryan May <rmay31@gmail.com>
@jhjensen2
Copy link

I agree to be a maintainer on the package

@hadim
Copy link
Member Author

hadim commented Jan 6, 2022

@dopplershift LGTM here

@dopplershift dopplershift merged commit fa08eef into conda-forge:main Jan 6, 2022
@hadim hadim deleted the xyz2mol branch January 6, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants