-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mkdocstrings-python-legacy, mkdocstrings-python, and griffe #18245
Conversation
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but couldn't find any. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python - This is ready for review 😄 Thanks! |
LGTM for me (not a conda forge reviewer but FYI). Do you think mkdocstrings-python and griffe should be packaged as well? Those are optional deps mkdocstrings, but I feel like users might want to have them by default too. |
I'm working on that for a different PR now. Probably submitted later today. |
Thanks for the work @bandersen23 ! |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/griffe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/staged-recipes This is ready to review! Thank you so much! This is for: conda-forge/mkdocstrings-feedstock#19 (comment) |
@conda-forge/staged-recipes the three feedstocks have an empty repo: |
Good catch. @chrisburr thanks for approving! Any idea why this might be? I know there's a lot going on so I wonder if the CI is busy? |
You can follow the logs of the CI here: https://github.com/conda-forge/staged-recipes/actions |
Awesome! I didn't know that, thanks for sharing! |
@BastianZim I looked at the logs for these three packages and they keep getting errors on the feedstock creation (I copied the error from one of the three feedstocks, but these three seem to be getting it: CI Summary for conda-forge/mkdocstrings-python-legacy-feedstock (can take ~30s):
[1264](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1264)
Traceback (most recent call last):
[1265](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1265)
File "/home/runner/Mambaforge/bin/conda-smithy", line 10, in <module>
[1266](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1266)
sys.exit(main())
[1267](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1267)
File "/home/runner/Mambaforge/lib/python3.9/site-packages/conda_smithy/cli.py", line 681, in main
[1268](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1268)
args.subcommand_func(args)
[1269](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1269)
File "/home/runner/Mambaforge/lib/python3.9/site-packages/conda_smithy/cli.py", line 296, in __call__
[1270](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1270)
ci_register.travis_configure(owner, repo)
[1271](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1271)
File "/home/runner/Mambaforge/lib/python3.9/site-packages/conda_smithy/ci_register.py", line 504, in travis_configure
[1272](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1272)
response.raise_for_status()
[1273](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1273)
File "/home/runner/Mambaforge/lib/python3.9/site-packages/requests/models.py", line 960, in raise_for_status
[1274](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1274)
raise HTTPError(http_error_msg, response=self)
[1275](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1275)
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://api.travis-ci.com/repo/22901922/setting/builds_only_with_travis_yml
[1276](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1276)
Traceback (most recent call last):
[1277](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1277)
File "/home/runner/work/staged-recipes/staged-recipes/.travis_scripts/create_feedstocks.py", line 283, in <module>
[1278](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1278)
subprocess.check_call(
[1279](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1279)
File "/home/runner/Mambaforge/lib/python3.9/subprocess.py", line 373, in check_call
[1280](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1280)
raise CalledProcessError(retcode, cmd)
[1281](https://github.com/conda-forge/staged-recipes/runs/5465015290?check_suite_focus=true#step:6:1281)
subprocess.CalledProcessError: Command '['conda', 'smithy', 'register-ci', '--without-appveyor', '--without-webservice', '--feedstock_directory', '/tmp/tmp9cn24gzc__feedstocks/mkdocstrings-python-legacy-feedstock', '--organization', 'conda-forge']' returned non-zero exit status 1. |
Yeah, that happens from time to time, unfortunately. Generally, this resolves itself after some hours, otherwise you can post in the gitter chat and someone from the respective team will have a look. |
Great, I'll check it later tonight and see how it's doing! 👍 |
@conda-forge/core - any thoughts on why these three recipe are not getting built? I just checked and noticed they still haven't been built, but they have an empty git repo. Is it a problem that the git repo was already created? They've been merged in for ~24 hours now and I keep seeing the same error on the |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).