Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mosquitto package #18387

Merged
merged 33 commits into from
May 14, 2022
Merged

added mosquitto package #18387

merged 33 commits into from
May 14, 2022

Conversation

nerohmot
Copy link
Contributor

@nerohmot nerohmot commented Mar 17, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mosquitto) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/mosquitto:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@nerohmot
Copy link
Contributor Author

@conda-forge/help-c-cpp could you please create the feedstock?
Will fix the osx-64 and osx-arm64 on the feedstock 😉 💯

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mosquitto) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/mosquitto:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

recipes/mosquitto/meta.yaml Outdated Show resolved Hide resolved
recipes/mosquitto/meta.yaml Outdated Show resolved Hide resolved
recipes/mosquitto/meta.yaml Outdated Show resolved Hide resolved
recipes/mosquitto/meta.yaml Outdated Show resolved Hide resolved
recipes/mosquitto/conda-forge.yml Show resolved Hide resolved
recipes/mosquitto/build.sh Outdated Show resolved Hide resolved
recipes/mosquitto/epl-v20 Outdated Show resolved Hide resolved
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mosquitto) and found it was in an excellent condition.

nerohmot and others added 3 commits March 18, 2022 16:44
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
recipes/mosquitto/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mosquitto) and found some lint.

Here's what I've got...

For recipes/mosquitto:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [29, 30]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mosquitto) and found it was in an excellent condition.

@nerohmot nerohmot requested a review from chrisburr May 7, 2022 19:41
@carterbox
Copy link
Member

You mean like this ?

Yes, those look like correct existence tests. Please also fix the linking/overdepending warnings.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mosquitto) and found some lint.

Here's what I've got...

For recipes/mosquitto:

  • The requirements section contained an unexpected subsection name. ignore_run_exports is not a valid subsection name.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mosquitto) and found some lint.

Here's what I've got...

For recipes/mosquitto:

  • The requirements section contained an unexpected subsection name. ignore_run_exports_from is not a valid subsection name.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mosquitto) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mosquitto) and found some lint.

Here's what I've got...

For recipes/mosquitto:

  • The top level meta key host is unexpected

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mosquitto) and found it was in an excellent condition.

Copy link
Member

@carterbox carterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding UCRT to the run requirements should be sufficient to solve that warning unless you want to patch upstream to strip unused symbols.

Comment on lines 27 to 30
- libxslt # [not win]
- ucrt # [win]
host:
- openssl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- libxslt # [not win]
- ucrt # [win]
host:
- openssl
host:
- openssl
run:
- ucrt # [win]

You seem to be having trouble with this.

@nerohmot Do you need the docs/manpages? It seems that libxslt is only used to build the documentation which is why no libraries link to it.

You can disable the documentation by adding -DDOCUMENTATION=OFF to the CMake args and then remove libxslt from the requirements. This would solve the overdepending problem.

Related: eclipse-mosquitto/mosquitto#2272

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx for the helping hand!
Indeed I am struggling with this one ☹️
... still I don't understand why the libxslt must go ...
Anyway, will do a you proposed and then work from there (including the -DDOCUMENTATION=OFF arg tip)

Copy link
Member

@carterbox carterbox May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the mosquitto README, it says that libxslt is only required to build to documentation, so if you don't want/need the docs in this package, then we can remove it from the build process. Do you want/need the docs?

When you put libxslt in the host section, it tells conda that this library should be linked against, so when the link inspector looks at the binaries in the libmosquitto package and doesn't find any links to libxslt it creates a warning because that could mean that libxslt is being statically linked (which is not allowed on conda forge). In this specific case, libxslt is not linked because it is not needed by the libmosquitto binaries according to the readme.

recipes/mosquitto/meta.yaml Outdated Show resolved Hide resolved
nerohmot and others added 2 commits May 13, 2022 21:40
Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
@carterbox
Copy link
Member

carterbox commented May 13, 2022

@nerohmot, if you give me permission to edit this branch, I will fix all the warnings for you.

https://github.com/carterbox/staged-recipes/tree/mosquitto

@nerohmot
Copy link
Contributor Author

@carterbox with permission I assume you mean to add you as collaborator to my fork of staged recipes ...
I did do so 😄 🙏 ... invite pending ... Thanx for you helping hand!!!

I took a look at https://github.com/carterbox/staged-recipes/tree/mosquitto

I could ofcourse pull from there, but it is more important (to me) to understand things, so next time around I know what to do from the start.

I thus went for the other option : no xslt and disable the documentation :-) I hope this is the way to do that.

@carterbox carterbox merged commit 5968d41 into conda-forge:main May 14, 2022
@carterbox
Copy link
Member

no xslt and no documentation is an acceptable solution. Take note of my branch if you decide that you need to build the docs later.

@carterbox
Copy link
Member

carterbox commented May 14, 2022

with permission I assume you mean to add you as collaborator to my fork of staged recipes

Yes, normally I should be able to push commits to PRs on conda-forge/staged-recipes, but I tried to do so yesterday and git said I didn't have permission. Maybe it's because Semiate is an organization instead of a user?

@nerohmot
Copy link
Contributor Author

Yes Semi-ATE is an organization, but I added you to Semi-ATE/staged-recipes, so you should have access now :-)
Many thanx for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants