-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added mosquitto package #18387
added mosquitto package #18387
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/mosquitto:
Documentation on acceptable licenses can be found here. |
@conda-forge/help-c-cpp could you please create the feedstock? |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but couldn't find any. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/mosquitto:
Documentation on acceptable licenses can be found here. |
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
Co-authored-by: Chris Burr <chrisburr@users.noreply.github.com>
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mosquitto:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Yes, those look like correct existence tests. Please also fix the linking/overdepending warnings. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mosquitto:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mosquitto:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mosquitto:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding UCRT to the run requirements should be sufficient to solve that warning unless you want to patch upstream to strip unused symbols.
recipes/mosquitto/meta.yaml
Outdated
- libxslt # [not win] | ||
- ucrt # [win] | ||
host: | ||
- openssl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- libxslt # [not win] | |
- ucrt # [win] | |
host: | |
- openssl | |
host: | |
- openssl | |
run: | |
- ucrt # [win] |
You seem to be having trouble with this.
@nerohmot Do you need the docs/manpages? It seems that libxslt is only used to build the documentation which is why no libraries link to it.
You can disable the documentation by adding -DDOCUMENTATION=OFF
to the CMake args and then remove libxslt from the requirements. This would solve the overdepending problem.
Related: eclipse-mosquitto/mosquitto#2272
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx for the helping hand!
Indeed I am struggling with this one
... still I don't understand why the libxslt must go ...
Anyway, will do a you proposed and then work from there (including the -DDOCUMENTATION=OFF
arg tip)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the mosquitto README, it says that libxslt is only required to build to documentation, so if you don't want/need the docs in this package, then we can remove it from the build process. Do you want/need the docs?
When you put libxslt in the host section, it tells conda that this library should be linked against, so when the link inspector looks at the binaries in the libmosquitto package and doesn't find any links to libxslt it creates a warning because that could mean that libxslt is being statically linked (which is not allowed on conda forge). In this specific case, libxslt is not linked because it is not needed by the libmosquitto binaries according to the readme.
Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
@nerohmot, if you give me permission to edit this branch, I will fix all the warnings for you. |
@carterbox with I took a look at https://github.com/carterbox/staged-recipes/tree/mosquitto I could ofcourse pull from there, but it is more important (to me) to understand things, so next time around I know what to do from the start. I thus went for the other option : no xslt and disable the documentation :-) I hope this is the way to do that. |
no xslt and no documentation is an acceptable solution. Take note of my branch if you decide that you need to build the docs later. |
Yes, normally I should be able to push commits to PRs on conda-forge/staged-recipes, but I tried to do so yesterday and git said I didn't have permission. Maybe it's because Semiate is an organization instead of a user? |
Yes Semi-ATE is an organization, but I added you to Semi-ATE/staged-recipes, so you should have access now :-) |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).