Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting recipes for GCC 5 and 6 from salford_systems #2089

Closed
wants to merge 2 commits into from
Closed

Porting recipes for GCC 5 and 6 from salford_systems #2089

wants to merge 2 commits into from

Conversation

holtgrewe
Copy link
Contributor

@holtgrewe holtgrewe commented Dec 16, 2016

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gcc-5, recipes/gcc-6, recipes/libgcc-5, recipes/libgcc-6) and found some lint.

Here's what I've got...

For recipes/gcc-5:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipes/gcc-6:

  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.

For recipes/libgcc-5:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'build', 'requirements', 'about'].
  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
  • The recipe must have some tests.
  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

For recipes/libgcc-6:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'build', 'requirements', 'about'].
  • The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
  • The recipe must have some tests.
  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gcc-5, recipes/gcc-6, recipes/libgcc-5, recipes/libgcc-6) and found some lint.

Here's what I've got...

For recipes/gcc-5:

  • There should be one empty line at the end of the file.

For recipes/gcc-6:

  • There should be one empty line at the end of the file.

For recipes/libgcc-5:

  • The recipe must have some tests.
  • There should be one empty line at the end of the file.

For recipes/libgcc-6:

  • The recipe must have some tests.
  • There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gcc-5, recipes/gcc-6, recipes/libgcc-5, recipes/libgcc-6) and found some lint.

Here's what I've got...

For recipes/libgcc-5:

  • The recipe must have some tests.

For recipes/libgcc-6:

  • The recipe must have some tests.

@holtgrewe
Copy link
Contributor Author

I would be interested in suggestions for tests for libgcc-?

Copy link

@dmaticzka dmaticzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about splitting this into dedicated PRs for versions 5 and 6, build time will be definitively an issue here.

For testing you could call some program linked against libgcc. Runtime tests are usually quite minimal, so anything linking against libgcc should be okay I guess.

# GCC relocates itself correctly under most circumstances, and 0001-.patch
# along with using ${GCC_PREFIX}/.. fixes the issues with our configuration.
build:
number: 2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be reset to 0

@stale
Copy link

stale bot commented Feb 13, 2020

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on master so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Feb 13, 2020
@stale
Copy link

stale bot commented Mar 14, 2020

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

3 participants