-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libcublas recipe #21901
Add libcublas recipe #21901
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcublas:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcublas:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcublas:
|
Instead of using a copy&paste license, refer to the LICENSE file already in the zip.
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcublas:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the wrong branch was started with, here are the 12.0.0 changes.
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcublas:
|
Thanks for the hint about v12. |
f52fb28
to
2a7cb77
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcublas:
|
2a7cb77
to
ae6fcba
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…inks can be resolved.
Update libcublas recipe.
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcublas:
|
Co-authored-by: jakirkham <jakirkham@gmail.com>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/core @conda-forge/staged-recipes, please take a look when you have a moment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no obvious problems with the recipe. I am curious as to why the cuda tests don’t pass and if we expect that.
Thanks Matt 🙏 Yeah that's expected since they are older CUDA versions. The relevant tests are the vanilla Linux and Windows tests (without CUDA) |
- test -L $PREFIX/lib/libcublas.so.{{ version }} # [linux] | ||
- test -L $PREFIX/lib/libcublas.so.{{ version.split(".")[0] }} # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen code that uses dlopen
/ dlsym
as well as ctypes
code that expects to use just the lib*.so
as opposed to the versioned shared library at runtime. Not a blocker, but have we considered having the libcublas.so
symlink in this package as opposed to the dev
package? I know that the SONAME
points to libcublas.so.12
, but there's definitely code out there that will end up requiring libcublas-dev
at runtime because of this.
Definitely not a blocker for getting this in though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been reworking RAPIDS code to use the proper SONAME form, like libcublas.so.12
, anywhere that we've seen that. I could see an argument that it's a bug to rely on dlopen
ing the unversioned form? That said, I don't have a reference for how we've packaged this in other CUDA Toolkit deployments to know if this approach is "normal" or not. I agree that we shouldn't treat this as a blocker, and I'd be happy to discuss further if users run into specific issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this should be easy to add if we decide. Let's turn this into an issue on the feedstock, which will make it easier to track as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised an issue ( conda-forge/libcublas-feedstock#1 )
Thanks all! 🙏 Let's get this in. We can iterate on anything else in the feedstock |
Thanks for all the help and work!! |
Hello all 👋
this is my first time adding a package to conda-forge. I followed the example
meta.yaml
and this recipe is based on the existing one forlibcublas
in the nvidia conda channel. I'll see what the CI robots say about this first attempt.@adibbley do you want to continue to be listed as maintainer for this recipe?
cc @jakirkham @adibbley
xref #21382
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).