Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ete3_external_apps #22132

Closed
wants to merge 30 commits into from

Conversation

marieBvr
Copy link

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ete3_external_apps) and found some lint.

Here's what I've got...

For recipes/ete3_external_apps:

  • about/license_family 'Multiple (OpenSource)' not allowed. Allowed
    families are AGPL, APACHE, BSD, CC, GPL, GPL2, GPL3, LGPL, MIT,
    MOZILLA, NONE, OTHER, PROPRIETARY, PSF, and PUBLIC-DOMAIN.

For recipes/ete3_external_apps:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ete3_external_apps) and found some lint.

Here's what I've got...

For recipes/ete3_external_apps:

  • about/license_family 'GPL-3.0-only' not allowed. Allowed families are
    AGPL, APACHE, BSD, CC, GPL, GPL2, GPL3, LGPL, MIT, MOZILLA, NONE,
    OTHER, PROPRIETARY, PSF, and PUBLIC-DOMAIN.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ete3_external_apps) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/ete3_external_apps:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ete3_external_apps) and found some lint.

Here's what I've got...

For recipes/ete3_external_apps:

  • requirements: host: numpy=1.16 must contain a space between the name and the pin, i.e. numpy =1.16
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/ete3_external_apps:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ete3_external_apps) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ete3_external_apps) and found some lint.

Here's what I've got...

For recipes/ete3_external_apps:

  • license_file entry is missing, but is required.

For recipes/ete3_external_apps:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ete3_external_apps) and found it was in an excellent condition.

@marieBvr
Copy link
Author

Hi @conda-forge/help-python-c,
I get an error related to the conda/mamba on Docker.
I can't do anything about this Docker, how can I move forward?

Your feedback would be appreciated. Thanks

@carterbox
Copy link
Member

carterbox commented Apr 1, 2023

Looks like this was a one time error. You can redo any build by closing and reopening your PR or by adding a new commit. You can also use the build-locally.py script to build locally if you have docker.

@marieBvr marieBvr closed this Apr 11, 2023
@marieBvr marieBvr reopened this Apr 11, 2023
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/ete3_external_apps) and found some lint.

Here's what I've got...

For recipes/ete3_external_apps:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [55]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ete3_external_apps) and found it was in an excellent condition.

@stale
Copy link

stale bot commented Sep 28, 2023

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Sep 28, 2023
@marieBvr marieBvr closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants