Add opentelemac #24529

nicogodet · 2023-11-18T12:57:06Z

Checklist

conda-forge-webservices · 2023-11-18T12:57:34Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/opentelemac) and found some lint.

Here's what I've got...

For recipes/opentelemac:

The recipe must have some tests.
Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [19, 36, 67]
license_file entry is missing, but is required.

For recipes/opentelemac:

Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.
License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-webservices · 2023-11-18T13:00:22Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/opentelemac) and found some lint.

Here's what I've got...

For recipes/opentelemac:

The recipe must have some tests.

For recipes/opentelemac:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-webservices · 2023-11-18T13:35:54Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/opentelemac) and found some lint.

Here's what I've got...

For recipes/opentelemac:

The recipe must have some tests.

conda-forge-webservices · 2023-11-18T17:30:32Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/opentelemac) and found it was in an excellent condition.

conda-forge-webservices · 2023-11-19T13:20:42Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/opentelemac) and found some lint.

Here's what I've got...

For recipes/opentelemac:

If python is a host requirement, it should be a run requirement.
Non noarch packages should have python requirement without any version constraints.

conda-forge-webservices · 2023-11-19T13:22:06Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/opentelemac) and found some lint.

Here's what I've got...

For recipes/opentelemac:

Non noarch packages should have python requirement without any version constraints.
Non noarch packages should have python requirement without any version constraints.

conda-forge-webservices · 2023-11-19T13:23:41Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/opentelemac) and found it was in an excellent condition.

github-actions · 2023-11-19T13:34:11Z

Hi! Thanks for your contribution to conda-forge.
Unfortunately, the recipe was added directly in the recipes folder without its own subfolder.
Please move the recipe file into a folder with the name of the package you want to submit.

For example: if your recipe is currently under recipes/<your_package>.yaml, it should be moved to recipes/<your_package>/meta.yaml.
Thanks!

nicogodet · 2023-11-19T14:57:22Z

@tomsail If you want to look at it...

nicogodet · 2023-11-19T15:17:26Z

@conda-forge-admin, please ping conda-forge/help-python

Because of a bug in f2py, we need for this package to use either numpy <=1.21 or numpy >=1.25 with provided patch.
I can't figure out the correct syntax in meta.yaml ou conda_build_config.yaml to respect these conditions.

conda-forge-webservices · 2023-11-19T15:17:33Z

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python and so here I am doing that.

conda-forge-webservices · 2023-11-19T16:35:13Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/opentelemac) and found some lint.

Here's what I've got...

For recipes/opentelemac:

Non noarch packages should have python requirement without any version constraints.
Non noarch packages should have python requirement without any version constraints.

tomsail · 2023-11-19T16:59:44Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/opentelemac) and found some lint.

Here's what I've got...

For recipes/opentelemac:

Non noarch packages should have python requirement without any version constraints.

Non noarch packages should have python requirement without any version constraints.

I will try this and let you know if it works

In meta.yaml:

requirements:
  host:
    - python
    - numpy 1.21.* | >=1.25
  run:
    - python
    - numpy 1.21.* | >=1.25

conda-forge-webservices · 2023-11-19T17:05:11Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/opentelemac) and found it was in an excellent condition.

tomsail · 2023-11-19T17:24:13Z

ok I have just seen your conda_build_config.yaml, ignore my comment above

tomsail · 2023-11-19T17:37:42Z

recipes/opentelemac/meta.yaml

@@ -85,7 +85,7 @@ outputs:
        - matplotlib-base
        - mpi4py
        - numpy >=1.25
-        - python >=3.9
+        - python >=3.9,<3.12


why wouldn't we include 3.12?

https://gitlab.pam-retd.fr/otm/telemac-mascaret/-/issues/946

ok, I don't think this is a priority on the opentelemac roadmap atm..

tomsail · 2023-11-19T17:49:53Z

recipes/opentelemac/meta.yaml

+    - {{ compiler('fortran') }}
+    - {{ compiler('c') }}
+    - {{ compiler('cxx') }}
+    - openmpi


we could also keep

- {{ mpi }} - {{ mpi }}-mpifort

to have more compiling possibilities

Yeah but let's do this once it's merged in feedstock

tomsail · 2023-11-19T17:55:15Z

recipes/opentelemac/meta.yaml

+source:
+  # - url: https://gitlab.pam-retd.fr/otm/telemac-mascaret/-/archive/{{ version }}/telemac-mascaret-{{ version }}.tar.gz
+  - url: https://github.com/nicogodet/otm-sources/releases/download/{{ version }}/telemac-mascaret-{{ version }}.tar.gz


why are you mirroring from your repo?

For a stripped source tarball excluding examples, documentation and notebooks (4mb against >1Gb tarball)

and http://www.opentelemac.org/index.php/kunena/feedback-and-suggestions/14015-provide-a-smaller-source-code-archive-on-gitlab

nicogodet · 2023-11-19T19:33:47Z

i accept to be listed as maintainer.

ping @tomsail @brey

nicogodet · 2023-11-19T19:34:20Z

It's ready for review @conda-forge/staged-recipes . Many thanks

nicogodet · 2023-11-20T09:37:08Z

@conda-forge-admin, please ping conda-forge/staged-recipes. This PR is ready for review.

conda-forge-webservices · 2023-11-20T09:37:12Z

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes. and so here I am doing that.

stale · 2024-05-04T11:28:32Z

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

tomsail · 2024-05-04T16:31:24Z

Hi @nicogodet, I'm keen to tackle this sometime in the following weeks. I'll ping you here when I catch up with the work you've done.

does windows release works in MPI without gotm? https://github.com/nicogodet/telemac-mascaret-feedstock

nicogodet · 2024-05-05T08:13:36Z

@tomsail No... MPI is a PIA on windows

conda-forge-webservices · 2024-05-14T15:07:44Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/opentelemac) and found some lint.

Here's what I've got...

For recipes/opentelemac:

The following maintainers have not yet confirmed that they are willing to be listed here: brey. Please ask them to comment on this PR if they are.

tomsail · 2024-05-24T12:41:12Z

@brey please look at the above message.
If you're not keen, I'll remove you from the recipe maintainers.

tomsail · 2024-05-24T13:01:46Z

recipes/opentelemac/meta.yaml

@@ -0,0 +1,81 @@
+{% set name = "opentelemac" %}
+{% set version = "v8p4r1" %}


please update to v8p5r0 and upload the archive on your github repo

While thinking back to it, it would be better to use archive from https://gitlab.pam-retd.fr/otm/telemac-mascaret

recipes/opentelemac/meta.yaml

brey · 2024-05-24T13:46:18Z

@brey please look at the above message. If you're not keen, I'll remove you from the recipe maintainers.

I think it's better if you remove me indeed. I am already in many places. Time to cut back

recipes/opentelemac/meta.yaml

ocefpaf · 2024-05-24T15:25:18Z

recipes/opentelemac/conda_build_config.yaml

@@ -0,0 +1,32 @@
+zip_keys:


Are you sure you need this? Conda-forge defaults are not working for you here?

thanks for the review felipe.
We have problems with certain versions of python/numpy (details there), hence the patch in recipes/opentelemac/patches.

I assume @nicogodet tried the conda-forge defaults

but I guess now we can remove this patch, since it has been integrated in main last year, correct?

conda-forge-webservices · 2024-05-24T15:26:20Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/opentelemac) and found it was in an excellent condition.

First commit

0ef8575

nicogodet mentioned this pull request Nov 18, 2023

Python / Numpy compilation and cross compatibility nicogodet/telemac-mascaret-feedstock#13

Open

github-actions bot added python review-requested labels Nov 19, 2023

nicogodet marked this pull request as draft November 19, 2023 15:18

tomsail reviewed Nov 19, 2023

View reviewed changes

nicogodet marked this pull request as ready for review November 19, 2023 19:32

nicogodet force-pushed the add-opentelemac branch 2 times, most recently from 40cfef7 to e7ae66d Compare November 20, 2023 08:11

Add opentelemac

bc37658

nicogodet force-pushed the add-opentelemac branch from e7ae66d to bc37658 Compare November 20, 2023 08:12

stale bot added the stale will be closed in 30 days label May 4, 2024

stale bot removed the stale will be closed in 30 days label May 4, 2024

BastianZim removed the review-requested label May 10, 2024

github-actions bot added the Awaiting author contribution label May 10, 2024

Merge branch 'main' into add-opentelemac

08cd648

tomsail reviewed May 24, 2024

View reviewed changes

recipes/opentelemac/meta.yaml Show resolved Hide resolved

nicogodet commented May 24, 2024

View reviewed changes

recipes/opentelemac/meta.yaml Outdated Show resolved Hide resolved

remove brey from maintainer

fdac133

ocefpaf reviewed May 24, 2024

View reviewed changes

tomsail added 4 commits May 24, 2024 17:56

added sustainable paths (de)activation

7d18488

added sed in host

8baeb9d

changed to the official repo

b924f5f

removed patch

4f27c99

ocefpaf merged commit d24a8c3 into conda-forge:main May 26, 2024
5 checks passed

		@@ -0,0 +1,81 @@
		{% set name = "opentelemac" %}
		{% set version = "v8p4r1" %}

Add opentelemac #24529

Add opentelemac #24529

Conversation

nicogodet commented Nov 18, 2023 • edited Loading

conda-forge-webservices bot commented Nov 18, 2023

conda-forge-webservices bot commented Nov 18, 2023

conda-forge-webservices bot commented Nov 18, 2023

conda-forge-webservices bot commented Nov 18, 2023

conda-forge-webservices bot commented Nov 19, 2023

conda-forge-webservices bot commented Nov 19, 2023

conda-forge-webservices bot commented Nov 19, 2023

github-actions bot commented Nov 19, 2023

nicogodet commented Nov 19, 2023

nicogodet commented Nov 19, 2023

conda-forge-webservices bot commented Nov 19, 2023

conda-forge-webservices bot commented Nov 19, 2023

tomsail commented Nov 19, 2023

conda-forge-webservices bot commented Nov 19, 2023

tomsail commented Nov 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicogodet commented Nov 19, 2023

nicogodet commented Nov 19, 2023

nicogodet commented Nov 20, 2023

conda-forge-webservices bot commented Nov 20, 2023

stale bot commented May 4, 2024

tomsail commented May 4, 2024

nicogodet commented May 5, 2024

conda-forge-webservices bot commented May 14, 2024

tomsail commented May 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brey commented May 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conda-forge-webservices bot commented May 24, 2024

nicogodet commented Nov 18, 2023 •

edited

Loading