-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the USNISTGOV SCTK (word error rate scoring toolkit) as a conda package #24726
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/sctk:
For recipes/sctk:
Documentation on acceptable licenses can be found here. |
Hi! Thanks for your contribution to conda-forge. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/sctk:
For recipes/sctk:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/sctk:
For recipes/sctk:
Documentation on acceptable licenses can be found here. |
- add build number: 0 as requested - license
@conda-forge-admin, please ping team @conda-forge/help-c-cpp I need help regarding the license file. Even though SPDX lists NIST-Software as a valid identifier, the linter complains about it. |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/sctk:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/sctk:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Co-authored-by: Filipe <ocefpaf@gmail.com>
recipes/sctk/meta.yaml
Outdated
sc_stats V1.3 - sclite's Statistical Significance Comparison tool | ||
rover V0.1 - Recognition Output Voting Error Reduction | ||
asclite V1.11 - Multidimensional alignment replacement for sclite | ||
license: LicenseRef-NIST-Software |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license: LicenseRef-NIST-Software | |
license: NIST-Software |
This license is not yet added to our linting tool. Probably because the list of allowed licenses hasn't been updated in a year. Please open a PR like this one on the conda-smithy feedstock with the updated licenses. (Note that there is a tool provided to autogenerate the list).
recipes/sctk/meta.yaml
Outdated
test: | ||
source_files: | ||
- makefile | ||
- src/** | ||
commands: | ||
- make check -C $SRC_DIR # [not win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to run make check, please do it as part of the build script instead of including a copy of the entire source tree in the package.
My understanding is that this package is a collection of CLI tools, so the tests section should be calling "$ tool --help" or like "$ tool --version", to check that they return without error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand. Unfortunately the developer did not add either option. What would be the recommendation in this case, simply checking for the existence of the files?
recipes/sctk/meta.yaml
Outdated
build: | ||
- {{ compiler('c') }} | ||
- {{ compiler('cxx') }} | ||
- cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- cmake |
There appears to be no CMakeLists.txt in the upstream project, so CMake is probably not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this change myself, should've "accepted your suggestion" instead. I would be glad if you could re-check.
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/pcaudiolib:
For recipes/pcaudiolib:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/sctk:
Documentation on acceptable licenses can be found here. |
@conda-forge-admin, please ping team @conda-forge/help-c-cpp, ready for review! |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, or conda-forge/help-ruby. Thanks! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).