Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mdsapt #24782

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Adding mdsapt #24782

merged 5 commits into from
Apr 2, 2024

Conversation

ifd3f
Copy link
Contributor

@ifd3f ifd3f commented Dec 14, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [ ] If static libraries are linked in, the license of the static library is packaged. N/A
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt) and found some lint.

Here's what I've got...

For recipes/mdsapt:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].
  • There are too few lines. There should be one empty line at the end of the file.
  • The extra section contained an unexpected subsection name. maintainers is not a valid subsection name.
  • requirements: run: psi4=1.8.1=*_2 must contain a space between the name and the pin, i.e. psi4 =1.8.1=*_2
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/mdsapt:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt) and found some lint.

Here's what I've got...

For recipes/mdsapt:

  • There are too few lines. There should be one empty line at the end of the file.
  • The extra section contained an unexpected subsection name. maintainers is not a valid subsection name.

@ifd3f ifd3f force-pushed the mdsapt-builder branch 2 times, most recently from a843cbc to 4caf40f Compare December 19, 2023 01:02
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt) and found some lint.

Here's what I've got...

For recipes/mdsapt:

  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt) and found some lint.

Here's what I've got...

For recipes/mdsapt:

  • The following maintainers have not yet confirmed that they are willing to be listed here: ALescoulie. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt) and found some lint.

Here's what I've got...

For recipes/mdsapt:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [12, 35]
  • The following maintainers have not yet confirmed that they are willing to be listed here: ALescoulie. Please ask them to comment on this PR if they are.
  • The test section contained an unexpected subsection name. skip is not a valid subsection name.
  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt) and found some lint.

Here's what I've got...

For recipes/mdsapt:

  • The following maintainers have not yet confirmed that they are willing to be listed here: ALescoulie. Please ask them to comment on this PR if they are.
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@ifd3f
Copy link
Contributor Author

ifd3f commented Feb 19, 2024

@ALescoulie do you want to be listed as a maintainer?

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt) and found some lint.

Here's what I've got...

For recipes/mdsapt:

  • The following maintainers have not yet confirmed that they are willing to be listed here: ALescoulie. Please ask them to comment on this PR if they are.

@ALescoulie
Copy link

@ALescoulie do you want to be listed as a maintainer?

yes I'd like to be a maintainer

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mdsapt) and found it was in an excellent condition.

@ifd3f
Copy link
Contributor Author

ifd3f commented Feb 22, 2024

@conda-forge/staged-recipes, ready for review

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@ifd3f
Copy link
Contributor Author

ifd3f commented Feb 22, 2024

@conda-forge/help-python

recipes/mdsapt/meta.yaml Outdated Show resolved Hide resolved
recipes/mdsapt/meta.yaml Outdated Show resolved Hide resolved
@ifd3f
Copy link
Contributor Author

ifd3f commented Mar 1, 2024

Hi @xhochy , I made the noarch change, could you look over this again?

recipes/mdsapt/meta.yaml Show resolved Hide resolved
recipes/mdsapt/meta.yaml Outdated Show resolved Hide resolved
@ifd3f ifd3f requested a review from xhochy March 11, 2024 21:49
recipes/mdsapt/meta.yaml Outdated Show resolved Hide resolved
@xhochy xhochy merged commit 9b01fec into conda-forge:main Apr 2, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants