-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add litestar 2.8.0 #25131
add litestar 2.8.0 #25131
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
ada248f
to
78c07d1
Compare
@conda-forge/starlite please comment here if you'd like to co-maintain. |
@bollwyvl sure happy to help |
@thewchan thanks, will update when i resolve |
yeah, |
Also the
|
@conda-forge/staged-recipes @conda-forge/help-python ready for review |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
@bollwyvl I understand that you want to bring your own tooling for maintaining the recipe and I know you will probably have good arguments to do so. However, we cannot handle that and the long lasting effects are unpredictable. Even though you use a different name for the template recipe, that can be confusing for existing (and future) parsing tools in conda-forge. Do you mind adapting that recipe to the custom format we support and remove the extra stuff? |
Happy to name the stuff whatever, put it wherever: is there some docs or prior art for examples? |
We don't have prior art in what you are trying to achieve. The core group did find two more recipes that ended up passing to the feedstock with those scripts and extra yaml file. See https://github.com/search?q=org%3Aconda-forge%20path%3A*.j2.yaml&type=code What we ask is that you use just the meta.yaml and remove the extra stuff. We are afraid that extra files that are not supported by conda-forge will cause confusing and can even break future iterations of our infrastructure. I know that this is frustrating but we are few and it is hard to accommodate custom stuff, specially if all maintainers start building their own! With all that said, if you believe what you are doing there could benefit the larger community, please get in touch with the bot team and work with them to see if we can assimilate those ideas. |
What if I just call it |
We would need some agreement with the @conda-forge/core group. I'm inclined to reduce the complexity if possible. |
The Windows build will fail, and that's probably OK. |
@conda-forge/staged-recipes ready for re-review |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
Some other package now depends on this conda-forge/evidently-feedstock#33 |
@conda-forge/core what do you think about this way for adding the recipe generator? |
Updated. Still anticipating fails on |
Any update on this? @bollwyvl @conda-forge/core |
(Nothing useful to add here, sorry, but I wanted to raise that projects I'm maintaining significantly wait for a bump of the blocked |
Past me approved this PR, and since then there have been negligible changes to the recipe. A recipe automation script was removed. #25131 (comment) , so I will merge. |
Thanks all. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).References:
Notes:
win-64
builds will fail on-with-cli
and-standard
due to lack of upstreamuvloop
support for that platformnoarch_platforms
or something, but doesn't really seem worth it