Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added qh3 as a package #25193

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Added qh3 as a package #25193

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d7fcf6f
Added qh3 as a package
thewchan Jan 31, 2024
7f6f02c
Add pylsqpack to host
thewchan Jan 31, 2024
eefd751
Put pylsqpack in build instead
thewchan Jan 31, 2024
4cf3838
Move C compiler and pylsqpack to host
thewchan Feb 5, 2024
046a42d
Move C compiler back to build
thewchan Feb 7, 2024
4a09d3e
Revamp recipe with >1.0.0 version
thewchan May 10, 2024
931ecd9
Add cmake to build
thewchan May 10, 2024
d821452
libclang to build
thewchan May 10, 2024
2c2d153
Add osx rust support and nasm to win build
thewchan May 10, 2024
e47773f
Bump cstdlib for osx and use clang instead of libclang
thewchan May 11, 2024
9c4a4f4
Use clangdev instead
thewchan May 11, 2024
f65dea4
Add openssl to host for osx, add c++ compiler for everyone
thewchan May 11, 2024
a1c9de4
AWS_LC_SYS_CMAKE_BUILDER=1
thewchan May 11, 2024
1220724
make to build
thewchan May 11, 2024
8d4f10c
Move clangdev to host
thewchan May 13, 2024
88790c3
Merge branch 'main' into qh3
xhochy May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions recipes/qh3/conda_build_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
c_stdlib_version: # [osx and x86]
- '10.12' # [osx and x86]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- '10.12' # [osx and x86]
- '10.13' # [osx and x86]

10.13 is now the new default/minimum

48 changes: 48 additions & 0 deletions recipes/qh3/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
{% set name = "qh3" %}
{% set version = "1.0.7" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/qh3-{{ version }}.tar.gz
sha256: eb527d8317746209509b9c575527577cdc9b3cfb0f49294fc1cd109b0570362c

build:
skip: True # [py<37]
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation
number: 0

requirements:
build:
- {{ stdlib('c') }}
- {{ compiler('c') }}
- {{ compiler('rust') }}
- cmake
- libclang # [linux]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- libclang # [linux]

This is something on PyPI only to reduce the size of binary artifacts (mostly?). In all recipes I have seen it, I just patched it out as a requirement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try Clang instead then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe I need to use Clang as the C compiler and not gcc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xhochy It seems that it's during the rust/cargo build phase it needs libclang, but not sure why it's not detecting it

- nasm # [win]
host:
- python
- maturin >=1.2,<2.0
- pip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- pip
- pip
- clangdev

This is probably what you need

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, let me try

run:
- python

test:
imports:
- qh3
commands:
- pip check
requires:
- pip

about:
home: https://github.com/jawah/qh3
summary: A lightway and fast implementation of QUIC and HTTP/3
license: BSD-3-Clause
license_file: LICENSE

extra:
recipe-maintainers:
- thewchan