Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add make-it-sync #25914

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 29, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [N/A] If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/make-it-sync) and found some lint.

Here's what I've got...

For recipes/make-it-sync:

  • The following maintainers have not yet confirmed that they are willing to be listed here: gordonwatts. Please ask them to comment on this PR if they are.

@matthewfeickert
Copy link
Member Author

@gordonwatts Can you comment below if you are willing to be a maintainer on this conda-forge recipe (required before a conda-forge maintainer can review this). (c.f. #25914 (comment)) As the package author I want to include you, but I am willing to do the maintenance of hitting "merge" if there are ever future releases of make-it-sync.

@matthewfeickert
Copy link
Member Author

👋 Going through my open PRs before signing off for the night, so @gordonwatts I thought I'd ping to get your comment here.

@gordonwatts
Copy link

gordonwatts commented Apr 29, 2024

Sorry - I've been distracted! Yes, I sign off! And thank you @matthewfeickert for doing this!!

@matthewfeickert
Copy link
Member Author

Sorry - I've been distracted! Yes, I sign off!

For very useful and important reasons, so thank you for pushing them forward and also for following up here! 👍

* c.f. https://github.com/gordonwatts/make-it-sync
* Recipe generated with grayskull via 'grayskull pypi make-it-sync'
  and then edited to add additional information.
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/make-it-sync) and found it was in an excellent condition.

@matthewfeickert
Copy link
Member Author

@conda-forge/help-python, ready for review

@ocefpaf ocefpaf merged commit eaf33d5 into conda-forge:main Apr 29, 2024
5 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-make-it-sync branch April 29, 2024 04:31
@matthewfeickert matthewfeickert mentioned this pull request Sep 10, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants