Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding auto-ts from PyPI #26194

Merged
merged 5 commits into from
May 2, 2024
Merged

Adding auto-ts from PyPI #26194

merged 5 commits into from
May 2, 2024

Conversation

sugatoray
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/auto-ts) and found some lint.

Here's what I've got...

For recipes/auto-ts:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/auto-ts) and found it was in an excellent condition.

@sugatoray sugatoray marked this pull request as ready for review April 30, 2024 22:31
@sugatoray
Copy link
Contributor Author

sugatoray commented Apr 30, 2024

PR is ready. Request for review/merging.

cc: @conda-forge/help-python @xhochy

@sugatoray
Copy link
Contributor Author

sugatoray commented Apr 30, 2024

Note for Reviewer(s)

I have made the following temporary changes to make the build pass.

  • Added temporary work-around steps to create the requirements.txt file dynamically.
  • Added LICENSE file from the GitHub repository.

However, a proper fix in the upstream repo is a desirable longterm solution. With that in mind, I have opened up the following issue:

And, also pushed the intended fix via the following PR:

cc: @AutoViML

@xhochy xhochy merged commit a697640 into conda-forge:main May 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants