-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for mrmr-selection
#26357
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/mrmr:
For recipes/mrmr:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Unfortunatley currently only the wheel is available on pypi. I've filed an issue upstream, see smazzanti/mrmr#45. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python, ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How I would use it exactly? Do you mean mentioning it as a comment, or smth else?
@svengiegerich something like this should work.
recipes/mrmr_selection/meta.yaml
Outdated
build: | ||
number: 0 | ||
noarch: python | ||
script: {{ PYTHON }} -m pip install {{ name }}-{{ version }}-py3-none-any.whl -vv --no-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script: {{ PYTHON }} -m pip install {{ name }}-{{ version }}-py3-none-any.whl -vv --no-deps | |
script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocefpaf I run into the following error,
Created temporary directory: /tmp/pip-ephem-wheel-cache-bm6ytv1h
Processing $SRC_DIR
Added file://$SRC_DIR to build tracker '/tmp/pip-build-tracker-7ghuechq'
Running setup.py (path:$SRC_DIR/setup.py) egg_info for package from file://$SRC_DIR
Created temporary directory: /tmp/pip-pip-egg-info-3zl4y3vm
Preparing metadata (setup.py): started
Running command python setup.py egg_info
Traceback (most recent call last):
File "<string>", line 2, in <module>
File "<pip-setuptools-caller>", line 34, in <module>
File "/home/conda/staged-recipes/build_artifacts/mrmr_selection_1715807740702/work/setup.py", line 2, in <module>
from mrmr import __version__
File "/home/conda/staged-recipes/build_artifacts/mrmr_selection_1715807740702/work/mrmr/__init__.py", line 1, in <module>
from . import bigquery
File "/home/conda/staged-recipes/build_artifacts/mrmr_selection_1715807740702/work/mrmr/bigquery.py", line 1, in <module>
import jinja2
ModuleNotFoundError: No module named 'jinja2'
error: subprocess-exited-with-error
do you know what I need to adjust? 'jinja2' is already listed in the requires.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know what I need to adjust? 'jinja2' is already listed in the requires.
Yes, you need all the dependencies listed here: https://github.com/smazzanti/mrmr/blob/dc8a810bc9d01b6fe20e8767de0098d4671b50b6/setup.py#L19-L26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but that's what I did. Compare, the recipe,
- python >=3.7
- category_encoders
- jinja2
- tqdm
- joblib
- pandas >=1.0.3
- numpy >=1.18.1
- scikit-learn
- scipy
- polars >=0.12.5
vs `setup.p ,
install_requires=[
'category_encoders',
'jinja2',
'tqdm',
'joblib',
'pandas>=1.0.3',
'numpy>=1.18.1',
'scikit-learn',
'scipy',
],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give me a sec to check it locally...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. It looks like the project imports itself at build time and need to be importable before being built. That is an old practice but buggy. If you can, please open an issue upstream. Our workaround is to specify all the run dependencies at build time too. I did that here for you. Let's see if that works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. It looks like the project imports itself at build time and need to be importable before being built. That is an old practice but buggy. If you can, please open an issue upstream.
Ah, I see! Thanks, I definitely will.
I did that here for you. Let's see if that works.
Worked 🙌 Thanks here!
Co-authored-by: Filipe <ocefpaf@gmail.com>
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).