Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add flaky recipe #2655

Merged
merged 1 commit into from
Mar 23, 2017
Merged

PR: Add flaky recipe #2655

merged 1 commit into from
Mar 23, 2017

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Mar 22, 2017

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flaky) and found it was in an excellent condition.

@goanpeca
Copy link
Member Author

@jakirkham all appveyor builds failed with :-(

screen shot 2017-03-21 at 7 57 42 pm

@ccordoba12
Copy link
Contributor

👍

@jakirkham
Copy link
Member

Yep, this is a known issue ( appveyor/ci#1426 ). Have already proposed fixes in PRs ( conda-forge/conda-smithy#489 ) and ( #2648 ). Please take a look.

@goanpeca
Copy link
Member Author

@jakirkham I saw the PR got merged, has the new version been released :-)

@mariusvniekerk
Copy link
Member

@goanpeca restarted your windows build

@goanpeca
Copy link
Member Author

goanpeca commented Mar 23, 2017

@mariusvniekerk thanks, but did not we need to update or re-render with the latest version of smithy?

@jakirkham
Copy link
Member

No need to re-render at staged-recipes. Literally just restarting the CIs should be sufficient (thanks @mariusvniekerk). Though feedstocks will need re-rendering, which can be done with 2.2.1 that was released earlier today.

@goanpeca
Copy link
Member Author

@jakirkham awesome work :-) thanks!

@goanpeca
Copy link
Member Author

@jakirkham merge :-) ?

@jakirkham jakirkham merged commit 5716f29 into conda-forge:master Mar 23, 2017
@jakirkham
Copy link
Member

Yep. 👍 Thanks @goanpeca.

@goanpeca goanpeca deleted the flaky branch September 15, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants