Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added recipe for plac #3998

Merged
merged 3 commits into from
Sep 21, 2017
Merged

Added recipe for plac #3998

merged 3 commits into from
Sep 21, 2017

Conversation

pmlandwehr
Copy link
Contributor

plac is a command line argument parser.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/plac) and found some lint.

Here's what I've got...

For recipes/plac:

  • The recipe license should not include the word "License".

@pmlandwehr pmlandwehr mentioned this pull request Sep 20, 2017
Closed
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/plac) and found it was in an excellent condition.

@jjhelmus jjhelmus merged commit 4aa157c into conda-forge:master Sep 21, 2017
@jjhelmus
Copy link
Contributor

thanks @pmlandwehr

isuruf
isuruf reviewed Sep 22, 2017
View reviewed changes
recipes/plac/meta.yaml
{{ hash_type }}: {{ hash }}

build:
number: {{ build }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding noarch: python here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point - can fix this when the feedstock is set up.

@pmlandwehr pmlandwehr deleted the plac branch September 22, 2017 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmlandwehr @conda-forge-linter @jjhelmus @isuruf