Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for Geotext #6316

Merged
merged 3 commits into from
Jul 23, 2018
Merged

Add recipe for Geotext #6316

merged 3 commits into from
Jul 23, 2018

Conversation

CurtLH
Copy link
Contributor

@CurtLH CurtLH commented Jul 21, 2018

No description provided.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/geotext) and found it was in an excellent condition.

@CurtLH
Copy link
Contributor Author

CurtLH commented Jul 21, 2018

The Windows build is failing because of the following reason:

import: 'geotext'
Traceback (most recent call last):
  File "C:\bld\geotext_1532138153816\test_tmp\run_test.py", line 2, in <module>
    import geotext
  File "C:\bld\geotext_1532138153816\_test_env\lib\site-packages\geotext\__init__.py", line 7, in <module>
    from .geotext import GeoText
  File "C:\bld\geotext_1532138153816\_test_env\lib\site-packages\geotext\geotext.py", line 87, in <module>
    class GeoText(object):
  File "C:\bld\geotext_1532138153816\_test_env\lib\site-packages\geotext\geotext.py", line 103, in GeoText
    index = build_index()
  File "C:\bld\geotext_1532138153816\_test_env\lib\site-packages\geotext\geotext.py", line 77, in build_index
    cities = read_table(get_data_path('cities15000.txt'), usecols=[1, 8])
  File "C:\bld\geotext_1532138153816\_test_env\lib\site-packages\geotext\geotext.py", line 54, in read_table
    for line in lines:
  File "C:\bld\geotext_1532138153816\_test_env\lib\site-packages\geotext\geotext.py", line 51, in <genexpr>
    lines = (line for line in f if not line.startswith(comment))
  File "C:\bld\geotext_1532138153816\_test_env\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 165: character maps to <undefined>
(C:\bld\geotext_1532138153816\_test_env) C:\bld\geotext_1532138153816\test_tmp>IF 1 NEQ 0 exit 1 

This same thing is seen in this issue

@CurtLH
Copy link
Contributor Author

CurtLH commented Jul 21, 2018

I have skipped the Windows build for now. I will rebuild the recipe once the issue is fixed. Otherwise, this one is ready for review @conda-forge/staged-recipes.

@scopatz scopatz merged commit 8454996 into conda-forge:master Jul 23, 2018
@CurtLH CurtLH deleted the geotext branch July 23, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants