Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphene-tornado #9763

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

kinow
Copy link
Member

@kinow kinow commented Oct 8, 2019

Pull request for graphene-tornado.

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vend other packages
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/graphene-tornado) and found it was in an excellent condition.

@kinow
Copy link
Member Author

kinow commented Oct 8, 2019

Added an issue there to tell the maintainers about the recipe being published here too: graphql-python/graphene-tornado#35

Here's what else I did locally when creating this recipe:

  • python setup.py sdist the graphene-tornado module, and confirmed there is a LICENSE file inside the source file
  • conda build . in the recipe folder, then conda install --use-local graphene-tornado, confirmed in the console output it was being installed from ~/anaconda3/conda-bld/...; then import graphene_tornado

We were using a similar recipe in a private channel to test out system that uses graphene-tornado: https://github.com/cylc/cylc-conda/blob/c4b692f5d9ba949b4005b1f390c498df3b62e758/recipes/graphene-tornado/meta.yaml

Oh, while testing locally, conda build . failed without the pytest dependency under host.

@marcelotrevisani marcelotrevisani merged commit 2c1db78 into conda-forge:master Oct 8, 2019
@kinow kinow mentioned this pull request Jan 14, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants