Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANIFEST.in appears to be ignored when running python setup.py bdist_conda #383

Closed
jakirkham opened this issue Apr 24, 2015 · 14 comments
Closed
Labels
locked [bot] locked due to inactivity stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity

Comments

@jakirkham
Copy link
Member

It seems that running python setup.py bdist_conda should be somewhat like bdist in that it uses MANIFEST.in to include files that it may not be including otherwise. However, this currently appears not to be the case.

@asmeurer
Copy link
Contributor

Does MANIFEST.in specify stuff things that actually get installed? I thought it was just extra things for the bdist tarball. Anyway, bdist_conda is currently based on install, since that's how conda build works.

@marscher
Copy link

This file is very central feature to distutils/setuptools projects, since one defines what is going to be installed and packaged (sdist, bdist etc.). So supporting this is IMHO crucial for operation. I just ran into this, since I'm installing test-data into my projects package via the manifest and it just got silently ignored.

Do you suggest a workaround until this (hopefully) gets fixed?

@marscher
Copy link

The funny thing is that the build-wrapper just does the normal install via setup.py, so the data should be there, but it is then not being packaged, when the conda package is created.

@marscher
Copy link

using test: files: list in meta.yaml seems to be a temporary workaround, but the conda package is not containing the same stuff as the pypi one. For example I explicitly want to ship the test data, so users can use them for their purposes.

@jakirkham
Copy link
Member Author

If it is data that you want, and you can use setuptools, you could try this ( https://pythonhosted.org/setuptools/setuptools.html#including-data-files ).

@marscher
Copy link

marscher commented Aug 18, 2015 via email

@marscher
Copy link

marscher commented Aug 18, 2015 via email

@marscher
Copy link

Please note that including data files works perfectly for my projects if only using setuptools. I can not spot the location in the conda build code where my files are being thrown away. Don't you just recursively include the newly installed package in the _build environment?

@marscher
Copy link

You're right @jakirkham. If one sets up a proper package_data in setup.py it works perfectly (and it has to, because its written like that). Actually I belive that setuptools/pip does some voodoo to fix missing package_data declarations by parsing the Manifest, but this is not official.

sorry @conda-devs! This issue can be closed as it also works in bdist_conda!

@jasongrout
Copy link

I also had a problem where conda build is not including files that the normal python setup.py build includes. It seems for me that the problem is that conda builds the manifest from MANIFEST.in before the install, and I add some files during the install that should be included. Maybe this is part of the issue?

@jakirkham
Copy link
Member Author

To be clear @marscher, I don't believe this can be closed. The fact that MANIFEST.in is ignored still presents a problem.

@wmayner
Copy link

wmayner commented Feb 9, 2018

Perhaps relevant: pypa/sampleproject#30

@bilderbuchi
Copy link
Contributor

@jakirkham do you still see this issue? I have a package that uses a MANIFEST.in with a recursive-include statement, which gets correctly parsed when I build with python setup.py bdist_conda, so I'm not sure if this still occurs.

william-silversmith added a commit to seung-lab/cloud-volume that referenced this issue Nov 11, 2018
Possibly on other platforms as well. Anaconda ignores MANIFEST.in

conda/conda-build#383
@github-actions
Copy link

Hi there, thank you for your contribution to conda-build!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue in the latest version of conda-build

  2. Comment that the issue is still reproducible and include:

  • What version of conda-build you reproduced the issue on
  • What OS and version you reproduced the issue on
  • What steps you followed to reproduce the issue
  1. It would also be helpful to have the output of the following commands available:
  • conda info
  • conda config --show-sources
  • conda list --show-channel-urls

NOTE: If this issue was closed prematurely, please leave a comment and we will gladly reopen the issue.

In case this issue was originally about a project that is covered by the Anaconda issue tracker (e.g. Anaconda, Miniconda, packages built by Anaconda, Inc. like Anaconda Navigator etc), please reopen the issue there again.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Feb 20, 2022
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label May 14, 2022
@github-actions github-actions bot added the locked [bot] locked due to inactivity label May 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity
Projects
None yet
Development

No branches or pull requests

6 participants