-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MANIFEST.in
appears to be ignored when running python setup.py bdist_conda
#383
Comments
Does MANIFEST.in specify stuff things that actually get installed? I thought it was just extra things for the bdist tarball. Anyway, |
This file is very central feature to distutils/setuptools projects, since one defines what is going to be installed and packaged (sdist, bdist etc.). So supporting this is IMHO crucial for operation. I just ran into this, since I'm installing test-data into my projects package via the manifest and it just got silently ignored. Do you suggest a workaround until this (hopefully) gets fixed? |
The funny thing is that the build-wrapper just does the normal install via setup.py, so the data should be there, but it is then not being packaged, when the conda package is created. |
using |
If it is data that you want, and you can use |
The problem with that approach is, that this files are then not included
in sdist, but only bdist commands.
If you tell me, where in conda-build those files are being stripped
away, I want to open a PR to change this. I'm pretty sure that this
behaviour is not expected by literally all external package managers and
it is very hard to spot, why things are failing - just because the
standard way of doing things is broken.
|
include_package_data=True in setuptools makes not difference either. The
files are just missing in the conda package.
|
Please note that including data files works perfectly for my projects if only using setuptools. I can not spot the location in the conda build code where my files are being thrown away. Don't you just recursively include the newly installed package in the _build environment? |
You're right @jakirkham. If one sets up a proper package_data in setup.py it works perfectly (and it has to, because its written like that). Actually I belive that setuptools/pip does some voodoo to fix missing package_data declarations by parsing the Manifest, but this is not official. sorry @conda-devs! This issue can be closed as it also works in bdist_conda! |
I also had a problem where conda build is not including files that the normal python setup.py build includes. It seems for me that the problem is that conda builds the manifest from MANIFEST.in before the install, and I add some files during the install that should be included. Maybe this is part of the issue? |
To be clear @marscher, I don't believe this can be closed. The fact that |
Perhaps relevant: pypa/sampleproject#30 |
@jakirkham do you still see this issue? I have a package that uses a MANIFEST.in with a |
Possibly on other platforms as well. Anaconda ignores MANIFEST.in conda/conda-build#383
Hi there, thank you for your contribution to This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this issue to remain open please:
NOTE: If this issue was closed prematurely, please leave a comment and we will gladly reopen the issue. In case this issue was originally about a project that is covered by the Anaconda issue tracker (e.g. Anaconda, Miniconda, packages built by Anaconda, Inc. like Anaconda Navigator etc), please reopen the issue there again. Thanks! |
It seems that running
python setup.py bdist_conda
should be somewhat likebdist
in that it usesMANIFEST.in
to include files that it may not be including otherwise. However, this currently appears not to be the case.The text was updated successfully, but these errors were encountered: