Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license file for R packages from CRAN #2831

Merged
merged 3 commits into from
Apr 24, 2018

Conversation

jdblischak
Copy link
Contributor

This PR adds the field license_file for CRAN R packages that use one of the complete licenses shipped with R.

xref: conda-forge/staged-recipes#3234

To demonstrate the new behavior:

$ cd conda-build
$ export PYTHONPATH=.
$ python bin/conda-skeleton cran r-abf2 r-ada r-adapr r-arc r-bigml r-far r-grnn  r-gsa r-udunits2 r-usethis
$ grep license[:_] r-*/meta.yaml
r-abf2/meta.yaml:  license: Artistic-2.0
r-abf2/meta.yaml:  license_family: OTHER
r-abf2/meta.yaml:  license_file: '{ environ["PREFIX"] }/lib/R/share/licenses/Artistic-2.0'  # [unix]
r-abf2/meta.yaml:  license_file: '{ environ["PREFIX"] }/R/share/licenses/Artistic-2.0'  # [win]
r-ada/meta.yaml:  license: GPL
r-ada/meta.yaml:  license_family: GPL
r-ada/meta.yaml:  license_file: '{ environ["PREFIX"] }/lib/R/share/licenses/GPL-3'  # [unix]
r-ada/meta.yaml:  license_file: '{ environ["PREFIX"] }/R/share/licenses/GPL-3'  # [win]
r-adapr/meta.yaml:  license: LGPL-2
r-adapr/meta.yaml:  license_family: LGPL
r-adapr/meta.yaml:  license_file: '{ environ["PREFIX"] }/lib/R/share/licenses/LGPL-2'  # [unix]
r-adapr/meta.yaml:  license_file: '{ environ["PREFIX"] }/R/share/licenses/LGPL-2'  # [win]
r-arc/meta.yaml:  license: AGPL-3
r-arc/meta.yaml:  license_family: AGPL
r-arc/meta.yaml:  license_file: '{ environ["PREFIX"] }/lib/R/share/licenses/AGPL-3'  # [unix]
r-arc/meta.yaml:  license_file: '{ environ["PREFIX"] }/R/share/licenses/AGPL-3'  # [win]
r-bigml/meta.yaml:  license: LGPL-3
r-bigml/meta.yaml:  license_family: LGPL
r-bigml/meta.yaml:  license_file: '{ environ["PREFIX"] }/lib/R/share/licenses/LGPL-3'  # [unix]
r-bigml/meta.yaml:  license_file: '{ environ["PREFIX"] }/R/share/licenses/LGPL-3'  # [win]
r-far/meta.yaml:  license: LGPL-2.1
r-far/meta.yaml:  license_family: LGPL
r-far/meta.yaml:  license_file: '{ environ["PREFIX"] }/lib/R/share/licenses/LGPL-2.1'  # [unix]
r-far/meta.yaml:  license_file: '{ environ["PREFIX"] }/R/share/licenses/LGPL-2.1'  # [win]
r-grnn/meta.yaml:  license: AGPL
r-grnn/meta.yaml:  license_family: AGPL
r-grnn/meta.yaml:  license_file: '{ environ["PREFIX"] }/lib/R/share/licenses/AGPL-3'  # [unix]
r-grnn/meta.yaml:  license_file: '{ environ["PREFIX"] }/R/share/licenses/AGPL-3'  # [win]
r-gsa/meta.yaml:  license: LGPL
r-gsa/meta.yaml:  license_family: LGPL
r-gsa/meta.yaml:  license_file: '{ environ["PREFIX"] }/lib/R/share/licenses/LGPL-3'  # [unix]
r-gsa/meta.yaml:  license_file: '{ environ["PREFIX"] }/R/share/licenses/LGPL-3'  # [win]
r-udunits2/meta.yaml:  license: GPL-2
r-udunits2/meta.yaml:  license_family: GPL2
r-udunits2/meta.yaml:  license_file: '{ environ["PREFIX"] }/lib/R/share/licenses/GPL-2'  # [unix]
r-udunits2/meta.yaml:  license_file: '{ environ["PREFIX"] }/R/share/licenses/GPL-2'  # [win]
r-usethis/meta.yaml:  license: GPL-3
r-usethis/meta.yaml:  license_family: GPL3
r-usethis/meta.yaml:  license_file: '{ environ["PREFIX"] }/lib/R/share/licenses/GPL-3'  # [unix]
r-usethis/meta.yaml:  license_file: '{ environ["PREFIX"] }/R/share/licenses/GPL-3'  # [win]

@msarahan
Copy link
Contributor

Please clean up flake8: https://travis-ci.org/conda/conda-build/jobs/370621211#L1409

CI looks fine otherwise - the fail on travis is unrelated.

@msarahan
Copy link
Contributor

Fixed for you. I wanted to get this in for the release that I am preparing.

@msarahan msarahan merged commit 8287c08 into conda:master Apr 24, 2018

license_file_template = '''\
license_file: '{{ environ["PREFIX"] }}/lib/R/share/licenses/{license}' # [unix]
license_file: '{{ environ["PREFIX"] }}/R/share/licenses/{license}' # [win]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the path changed in the new anaconda r-base version? cc @mingwandroid

@jdblischak
Copy link
Contributor Author

Thanks @msarahan!

How soon are you planning on the next release? How to handle the license can be a contentious issue, so I'd prefer to have some time for the community to comment.

@msarahan
Copy link
Contributor

just tagged. Might need to tag 3.9.1 soon, depending on what @mingwandroid has to say about the point that @isuruf raised.

@mingwandroid
Copy link
Contributor

Yeah the path has changed. But I need to make a PR to r-base before you can use that. Will try to do that tonight.

Also we may want to unify on mran snapshots as the default cran mirror here?

msarahan added a commit to msarahan/conda-build that referenced this pull request Apr 24, 2018
msarahan added a commit that referenced this pull request Apr 24, 2018
revert #2831, Add license file for R packages from CRAN
@jdblischak
Copy link
Contributor Author

For my future self, xref: #2835 and conda-forge/r-base-feedstock#43

@github-actions
Copy link

Hi there, thank you for your contribution!

This pull request has been automatically locked because it has not had recent activity after being closed.

Please open a new issue or pull request if needed.

Thanks!

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2022
@jdblischak jdblischak deleted the cran-license branch April 21, 2022 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants