-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add license file for R packages from CRAN #2831
Conversation
Please clean up flake8: https://travis-ci.org/conda/conda-build/jobs/370621211#L1409 CI looks fine otherwise - the fail on travis is unrelated. |
Fixed for you. I wanted to get this in for the release that I am preparing. |
|
||
license_file_template = '''\ | ||
license_file: '{{ environ["PREFIX"] }}/lib/R/share/licenses/{license}' # [unix] | ||
license_file: '{{ environ["PREFIX"] }}/R/share/licenses/{license}' # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the path changed in the new anaconda r-base version? cc @mingwandroid
Thanks @msarahan! How soon are you planning on the next release? How to handle the license can be a contentious issue, so I'd prefer to have some time for the community to comment. |
just tagged. Might need to tag 3.9.1 soon, depending on what @mingwandroid has to say about the point that @isuruf raised. |
Yeah the path has changed. But I need to make a PR to r-base before you can use that. Will try to do that tonight. Also we may want to unify on mran snapshots as the default cran mirror here? |
revert #2831, Add license file for R packages from CRAN
For my future self, xref: #2835 and conda-forge/r-base-feedstock#43 |
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
This PR adds the field
license_file
for CRAN R packages that use one of the complete licenses shipped with R.xref: conda-forge/staged-recipes#3234
To demonstrate the new behavior: