Another attempt to add license file to CRAN recipes. #3284
Conversation
|
Yep, tests should probably go into test_api_skeleton.py. I don't understand your question about structure, though. Maybe I'll just point out the fixtures in https://github.com/conda/conda-build/blob/master/tests/conftest.py - these are what you'll see most often as inputs to test functions, and they help set up default configs and such. There's also testing_workdir for having a temporary work folder. If you use testing_config, it implicitly uses testing_workdir and you don't need to add testing_workdir also. |
|
Let me know if you need further guidance on tests. I'm fine with this PR - just waiting on you to comment on tests. |
jdblischak
force-pushed
the
cran-license-2
branch
from
ce3cba2
to
5f8da0b
Compare
@msarahan Thanks. I'll give it a try and let you know if I have any specific questions. |
|
@msarahan I converted my examples to tests. They pass locally. Please let me know if you'd like me to make any changes. |
|
Yep, all looks good to me. Thanks! |
|
Hi there, thank you for your contribution! This pull request has been automatically locked because it has not had recent activity after being closed. Please open a new issue or pull request if needed. Thanks! |
Now that the installation path for R is the same across all operating systems (conda-forge/r-base-feedstock#61), I am resubmitting an updated version of my previous PR (#2831) to add the license file to recipes of R packages that use the standard licenses shipped with R base.
Here are some examples:
License: GPL-3)license_file: '{{ environ["PREFIX"] }}/lib/R/share/licenses/GPL-3'License: Artistic-2.0)license_file: '{{ environ["PREFIX"] }}/lib/R/share/licenses/Artistic-2.0'License: Artistic License 2.0)license_file: '{{ environ["PREFIX"] }}/lib/R/share/licenses/Artistic-2.0'License: MPL)license_fileline addedI'd like to convert these examples into unit tests. I'm guessing that the appropriate location to add them is in https://github.com/conda/conda-build/blob/master/tests/test_api_skeleton.py, but I'd appreciate some guidance on how best to proceed with structuring the tests before I attempt this.
cc: @msarahan @mingwandroid @isuruf @bgruening
xref: #2831, #2835, conda-forge/staged-recipes#3234, conda-forge/r-base-feedstock#61