Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sys.exit calls in conda_build/inspect_pkg.py #5393

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

beeankha
Copy link
Contributor

Description

Replacing sys.exit call in a few functions in conda_build/inspect_pkgs.py with the new CondaBuildUserError exception for better error handling, along with corresponding unit tests.

The changes in this PR are separated out from work previously done by @kenodegard in #5255
Xref #4209

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@beeankha beeankha added the type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package label Jun 28, 2024
@beeankha beeankha requested a review from a team as a code owner June 28, 2024 17:17
@beeankha beeankha changed the title Replace sys.exit calls in conda_build/inspect_pkg.py Replace sys.exit calls in conda_build/inspect_pkg.py Jun 28, 2024
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jun 28, 2024
Copy link

codspeed-hq bot commented Jun 28, 2024

CodSpeed Performance Report

Merging #5393 will not alter performance

Comparing beeankha:remove-sys.exit-inspect_pkg (fd30868) with main (6d7805c)

Summary

✅ 3 untouched benchmarks

@beeankha
Copy link
Contributor Author

pre-commit.ci autofix

beckermr
beckermr previously approved these changes Jul 1, 2024
@beeankha beeankha enabled auto-merge (squash) July 2, 2024 17:33
@beeankha beeankha disabled auto-merge July 3, 2024 02:20
@beeankha beeankha enabled auto-merge (squash) July 9, 2024 16:58
@beeankha beeankha merged commit 4fd7d54 into conda:main Jul 9, 2024
28 checks passed
@beeankha beeankha mentioned this pull request Jul 16, 2024
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants