Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate errors with new --prune tests #267

Closed
wants to merge 9 commits into from

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Aug 24, 2023

Description

conda/conda#9614 introduced new tests for --prune which are now failing here. Let's investigate what's going on. We'll either fix or skip/xfail to keep CI in the other PRs.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 24, 2023
@jaimergp jaimergp marked this pull request as ready for review August 28, 2023 07:51
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the test errors are related or not

conda_libmamba_solver/__init__.py Outdated Show resolved Hide resolved
Comment on lines +30 to +31
# Message expected, but libmamba does not report constraints
"test_update_prune_5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we can tweak in the upstream test to work better here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. libmamba's implementation doesn't really report that kind of thing so if anything we have to add more messaging to conda-libmamba-solver wrapping logic.

@jezdez
Copy link
Member

jezdez commented Aug 29, 2023

pre-commit.ci autofix

@jaimergp jaimergp marked this pull request as draft August 29, 2023 16:25
@jaimergp
Copy link
Contributor Author

Will be superseded by #270

@jaimergp jaimergp closed this Sep 14, 2023
@jaimergp jaimergp deleted the investigate-test-prune-errors branch November 7, 2023 10:24
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants