Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to upgrade poetry version #310

Closed
wants to merge 3 commits into from

Conversation

mariusvniekerk
Copy link
Collaborator

Attempt to upgrade our vendored poetry to latest

@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 6937de0
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/63bf373332d8dd000888e6bb
😎 Deploy Preview https://deploy-preview-310--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mariusvniekerk
Copy link
Collaborator Author

mariusvniekerk commented Jan 11, 2023

@maresb tried to run the vendoring helper, but it seems that it didn't replace the import paths appropriately.

Actually seems it didn't really run? Can't seem to run the reset

Cannot reset migration stage 8 when not on a migration commit

No idea what this means

@maresb
Copy link
Contributor

maresb commented Jan 12, 2023

Hi, sorry for the confusion.

The original vendoring procedure was quite complicated. My migration script was designed to run once, and only with that specific version of Poetry/Poetry Core/Cleo. (The idea was to implement it in code so that when it comes time to upgrade we know exactly what procedure was used, and we can make the appropriate changes.) Thus the migration named "Vendor Poetry" has already been applied.

The migrate-code reset command runs git reset to undo previously-applied migration commits, but this only works when HEAD is a migration commit.

Rather than add an EPOCH I'd suggest m = Migration("Upgrade poetry to v1.3.2").

Taking a quick look, seems that we need to change vendor_helpers.py line 104 to

            f"/{self.name.replace('-', '_')}-{self.version}.tar.gz"

and line 390 to

                {"python_version": python_version, "sys_platform": "linux"},

but then it's getting confused due to importlib_metadata having multiple python_version requirements. I'll try to look into this soon.

@maresb
Copy link
Contributor

maresb commented Sep 8, 2024

Superseded by #637

@maresb maresb closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants