Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move/absorb auxlib #11025

Merged
merged 5 commits into from
Nov 12, 2021
Merged

Move/absorb auxlib #11025

merged 5 commits into from
Nov 12, 2021

Conversation

kenodegard
Copy link
Contributor

In seeking to do #10778 we found that auxlib has deviated enough from the source that we are (currently) uninterested in trying to address this discrepancy.

As a short term solution we will move auxlib from conda._vendor to conda itself and work to eliminate dead code and otherwise refactor/absorb it into the conda.utils submodule.

@anaconda-issue-bot anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 5, 2021
@kenodegard kenodegard mentioned this pull request Nov 5, 2021
Merged
@kenodegard kenodegard marked this pull request as ready for review November 6, 2021 14:41
@kenodegard kenodegard requested a review from a team as a code owner November 6, 2021 14:41
@kenodegard kenodegard changed the title [WIP] Move/absorb auxlib Move/absorb auxlib Nov 6, 2021
jezdez
jezdez approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you only add a comment to the auxlib/__init__.py file to explain the purpose of this move?

jezdez
jezdez approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kenodegard!

@kenodegard kenodegard merged commit 05b3e79 into conda:master Nov 12, 2021
@kenodegard kenodegard deleted the auxlib branch November 12, 2021 21:33
@jezdez jezdez mentioned this pull request Nov 23, 2021
Closed
@JanuszL JanuszL mentioned this pull request Nov 23, 2021
Closed
FaustinCarter pushed a commit to FaustinCarter/conda that referenced this pull request Nov 27, 2021
@kenodegard @pre-commit-ci @FaustinCarter
Move/absorb auxlib (conda#11025)
4298f61 
* Moved auxlib

* Update auxlib imports

* Fix auxlib flake8 failures

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Documenting why this move occurred

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kenodegard kenodegard mentioned this pull request Mar 15, 2022
Closed
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jezdez jezdez jezdez approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenodegard @jezdez @anaconda-issue-bot