-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include patches used in conda-standalone #85
Conversation
…unAsAdmin when the user is not admin
…specify `root_prefix`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems certainly like a good feature, but it'd be splendid to have test coverage for the new parameter. Do you think the current tests are capable of handling this?
I added tests, which create conda environment to check the existence of the shortcut and its name. |
@jezdez, could you please have a look at this PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests!
A new release would be convenient to make a new build of |
See conda-forge/conda-standalone-feedstock#18 (comment) and subsequent discussion. |
@ericpre Thanks for the pointers, I'll let @chenghlee answer that since he did the last release. |
Handling other things today, but I'll make sure we get a new release tagged by Monday. |
Thanks @chenghlee. We might need a |
These two commits are used as patch in conda-forge/conda-standalone-feedstock#18.