Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include patches used in conda-standalone #85

Merged
merged 4 commits into from
Aug 26, 2021

Conversation

ericpre
Copy link
Contributor

@ericpre ericpre commented Aug 2, 2021

These two commits are used as patch in conda-forge/conda-standalone-feedstock#18.

@ericpre ericpre requested a review from a team as a code owner August 2, 2021 17:16
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems certainly like a good feature, but it'd be splendid to have test coverage for the new parameter. Do you think the current tests are capable of handling this?

@ericpre
Copy link
Contributor Author

ericpre commented Aug 3, 2021

I added tests, which create conda environment to check the existence of the shortcut and its name.

@ericpre
Copy link
Contributor Author

ericpre commented Aug 16, 2021

@jezdez, could you please have a look at this PR? Thanks!

@chenghlee chenghlee self-assigned this Aug 25, 2021
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests!

@jezdez jezdez merged commit e42209a into conda:master Aug 26, 2021
@isuruf
Copy link
Contributor

isuruf commented Aug 26, 2021

Thanks @ericpre.
@jezdez, are there any plans for a new release?

@ericpre
Copy link
Contributor Author

ericpre commented Aug 27, 2021

A new release would be convenient to make a new build of conda-standalone without having to patch menuinst: it should be possible to simplify the conda-standalone recipe by using the menuinst package, instead of downloading the menuinst source and patching it when building conda-standalone!

@ericpre
Copy link
Contributor Author

ericpre commented Aug 27, 2021

See conda-forge/conda-standalone-feedstock#18 (comment) and subsequent discussion.

@jezdez
Copy link
Member

jezdez commented Aug 27, 2021

@ericpre Thanks for the pointers, I'll let @chenghlee answer that since he did the last release.

@chenghlee
Copy link
Contributor

Handling other things today, but I'll make sure we get a new release tagged by Monday.

@isuruf
Copy link
Contributor

isuruf commented Aug 27, 2021

Thanks @chenghlee. We might need a constructor release too.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants