fix: page.title() is called before the page is closed

Author: condorheroblog

packages/vuepress-plugin-export-pdf-core/package.json

@@ -55,7 +55,7 @@
 		"cac": "^6.7.14",
 		"envinfo": "^7.8.1",
 		"fs-extra": "^11.1.1",
-		"html-export-pdf-cli": "^1.1.0",
+		"html-export-pdf-cli": "^1.1.1",
 		"multimatch": "^6.0.0",
 		"ora": "^6.3.0",
 		"pdfjs": "^2.4.7",

packages/vuepress-plugin-export-pdf-core/src/generatePdf.ts

@@ -110,13 +110,14 @@ export const generatePdf = async ({
 		}
 
 		await printer.render(location);
+		const headTitle = title || await page.title();
 		const data = await printer.pdf(location, {
 			format: "A4",
 			...pdfOptions,
 		});
 		await writeFileSafe(pagePath, data);
 
-		const headTitle = title || await page.title();
+		await printer.closePage(location);
 		singleBar.increment(1, { headTitle });
 	}
 

packages/vuepress-plugin-export-pdf-v1/package.json

@@ -61,7 +61,7 @@
 		"debug": "^4.3.4"
 	},
 	"devDependencies": {
-		"@condorhero/vuepress-types": "^2.0.0",
+		"@condorhero/vuepress-types": "^2.0.1",
 		"@types/debug": "^4.1.7",
 		"vuepress": "^1.9.9"
 	},

packages/vuepress-plugin-export-pdf-v1/src/serverApp.ts

@@ -59,13 +59,15 @@ export const serverApp = async (dir = "docs", commandOptions: ICommandOptions =
 		outlineContainerSelector,
 	} = userConfig;
 
+	// https://github.com/vuejs/vuepress/blob/daa6404bf7b46331d0751af58a2c8a6c5c7cc3f9/packages/%40vuepress/core/lib/node/App.js#L468
 	const devContext = await dev({
 		sourceDir,
 		clearScreen: false,
 		theme,
 	});
 
 	await new Promise((resolve) => {
+		// https://github.com/vuejs/vuepress/blob/38e98634af117f83b6a32c8ff42488d91b66f663/packages/%40vuepress/core/lib/node/dev/index.js#L242
 		devContext.devProcess.server.compiler.hooks.done.tap("webpack-dev-server", () => {
 			process.stdout.write("VuePress dev server compiler done\n");
 			resolve(true);
@@ -102,6 +104,5 @@ export const serverApp = async (dir = "docs", commandOptions: ICommandOptions =
 	}
 
 	// close current dev server
-	devContext.devProcess.server.close();
-	process.exit(0);
+	devContext.devProcess.server.close(() => process.exit(0));
 };

packages/vuepress-plugin-export-pdf-v2/src/serverApp.ts

@@ -1,4 +1,5 @@
 import { join } from "node:path";
+import { createRequire } from "node:module";
 import { createDevApp, defaultTheme, viteBundler } from "vuepress";
 import debug from "debug";
 import type { CommandOptions } from "@condorhero/vuepress-plugin-export-pdf-core";
@@ -9,7 +10,11 @@ import type { UserConfig } from ".";
 
 const devDebug = debug("vuepress-plugin-export-pdf-v2:dev-server");
 
+export const moduleRequire = createRequire(import.meta.url);
+const { version } = moduleRequire("vuepress/package.json");
+
 export const serverApp = async (dir = "docs", commandOptions: CommandOptions = {}) => {
+	checkEnv("VuePress", pkg.engines.node, version, pkg.peerDependencies.vuepress);
 	const sourceDir = join(process.cwd(), dir);
 
 	if (commandOptions.debug)
@@ -60,7 +65,6 @@ export const serverApp = async (dir = "docs", commandOptions: CommandOptions = {
 		host: "localhost",
 		port: 8714,
 	});
-	checkEnv("VuePress", pkg.engines.node, devApp.version, pkg.peerDependencies.vuepress);
 
 	// initialize and prepare
 	await devApp.init();
@@ -94,6 +98,6 @@ export const serverApp = async (dir = "docs", commandOptions: CommandOptions = {
 	}
 
 	// close current dev server
-	closeDevServer();
+	await closeDevServer();
 	process.exit(0);
 };

packages/vuepress-types/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@condorhero/vuepress-types",
-	"version": "2.0.1",
+	"private": "true",
 	"description": "VuePress TypeScript helpers for 1.x",
 	"author": "CondorHero",
 	"license": "MIT",