Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handler test coverage added #128

Commits on Apr 14, 2024

  1. Fix of exception handler trying to write response to a disconnected c…

    …lient
    
    Why:
    On Conductor server side, an exception gets raised
    `Failure in @ExceptionHandler com.netflix.conductor.rest.controllers.ApplicationExceptionMapper#handleAll(HttpServletRequest, Throwable)`.
    Cause is attempting to write while the client aborted the connection
    `org.apache.catalina.connector.ClientAbortException: java.io.IOException: Broken pipe`, while the exception was wrapped in `ClosedChannelException`.
    
    What:
    Added a ClosedChannelException handler for such exceptions root caused by
    ClientAbortException.
    
    Testing done: Local run. Not trivial to emulate the issue in a test.
    Such a test may rely on timing out the client before server responded.
    
    Signed-off-by: Iva Avramova <ikoleva@vmware.com>
    ivakoleva committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    b6ec55f View commit details
    Browse the repository at this point in the history
  2. Fix of exception handler trying to write response to a disconnected c…

    …lient
    
    Why:
    On Conductor server side, an exception gets raised
    `Failure in @ExceptionHandler com.netflix.conductor.rest.controllers.ApplicationExceptionMapper#handleAll(HttpServletRequest, Throwable)`.
    Cause is attempting to write while the client aborted the connection
    `org.apache.catalina.connector.ClientAbortException: java.io.IOException: Broken pipe`, while the exception was nested in `ClosedChannelException`.
    
    What:
    Added a ClosedChannelException handler for exception chain containing
    ClientAbortException.
    
    Testing done: Local run. Not trivial to emulate the issue in a test.
    Such a test may rely on timing out the client before server responded.
    
    Signed-off-by: Iva Avramova <ikoleva@vmware.com>
    ivakoleva committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    f1a1afe View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. added tests; generalized the exception

    Signed-off-by: Iva Avramova <ikoleva@vmware.com>
    ivakoleva committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    2e919e5 View commit details
    Browse the repository at this point in the history
  2. added tests; generalized the exception

    Signed-off-by: Iva Avramova <ikoleva@vmware.com>
    ivakoleva committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ef267ad View commit details
    Browse the repository at this point in the history
  3. Why:

    Ignoring a particular exception based on its stack trace
    should be rather an alerting concern.
    
    What:
    Reverted ClientAbortedException specific handler.
    Added test coverage for the existing exception handler.
    
    Testing done: local run
    
    Signed-off-by: Iva Avramova <ikoleva@vmware.com>
    ivakoleva committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0376d7c View commit details
    Browse the repository at this point in the history