tests/e2e: General fixes to the operator script #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldoktor
reviewed
Jan 24, 2024
tests/e2e/operator.sh
Outdated
| @@ -266,7 +265,7 @@ wait_for_stabilization() { | |||
| count=0 | |||
| while true; do | |||
| change=0 | |||
| pod_info=$(kubectl get pods -n confidential-containers-system -o=jsonpath='{range .items[*]}{.metadata.name}{" "}{range .status.containerStatuses[*]}{.name}{" "}{.restartCount}{"\n"}{end}{end}') | |||
| pod_info=$(kubectl get pods -n $op_ns -o=jsonpath='{range .items[*]}{.metadata.name}{" "}{range .status.containerStatuses[*]}{.name}{" "}{.restartCount}{"\n"}{end}{end}') | |||
There was a problem hiding this comment.
To be sure it'd be better to quotate the $op_ns (just in case a space/whatever-weird-char is ever added)
ldoktor
reviewed
Jan 24, 2024
GabyCT
force-pushed
the
topic/fixoperatorscript
branch
from
b3e70e1
to
447cdc3
Compare
@ldoktor thanks for the feedback and changes applied :) |
|
lgtm! |
wainersm
approved these changes
Jan 29, 2024
|
Let's see if #342 fixes the e2e-pr failures |
This PR introduces general fixes to the test/e2e operator script, like fixing the indentation, using a variable that has been already declared and use in the script. Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
GabyCT
force-pushed
the
topic/fixoperatorscript
branch
from
447cdc3
to
25ab0f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces general fixes to the test/e2e operator script, like fixing the indentation, using a variable that has been already declared and use in the script.