Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove per file scan timeout #30

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Remove per file scan timeout #30

merged 2 commits into from
Jul 25, 2024

Conversation

z4kn4fein
Copy link
Member

@z4kn4fein z4kn4fein commented Jul 25, 2024

Describe the purpose of your pull request

Upon scanning, each file reading task had a timeout set (1 min). With too many tasks running parallel, while a task's timeout counter started ticking, its execution remained in a suspended state. Eventually, it was cancelled due to the timeout, even if it was supposed to work on a fairly small file, so nothing really justified the timeout.

Now, only the whole scanning process has a timeout (30 min), and the /file timeouts were removed.

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@z4kn4fein z4kn4fein requested a review from a team as a code owner July 25, 2024 13:31
@z4kn4fein z4kn4fein merged commit b6caae5 into main Jul 25, 2024
31 checks passed
@z4kn4fein z4kn4fein deleted the remove-scan-file-timeout branch July 25, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants