Stateless parser #6

bandesz · 2018-05-18T08:23:56Z

This is a major refactor of the library with a lot of API changes.

…ed NamedFunc struct

Also the terminals should not return with an error when there is no match.

…moize

…have the name when we create a parser

…ful message

….GetResult

codecov-io · 2018-05-18T08:24:44Z

Codecov Report

Merging #6 into master will increase coverage by 1.21%.
The diff coverage is 93.35%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   92.62%   93.84%   +1.21%     
==========================================
  Files          31       38       +7     
  Lines         732      828      +96     
==========================================
+ Hits          678      777      +99     
+ Misses         52       44       -8     
- Partials        2        7       +5

Impacted Files	Coverage Δ
data/intset.go	`100% <ø> (ø)`	⬆️
data/intmap.go	`100% <ø> (ø)`	⬆️
examples/json/json/parser.go	`0% <0%> (ø)`	⬆️
text/terminal/float.go	`100% <100%> (ø)`	⬆️
ast/interpreter/interpreter.go	`100% <100%> (ø)`
text/reader.go	`100% <100%> (ø)`	⬆️
parsley/parsley.go	`100% <100%> (ø)`	⬆️
combinator/any.go	`100% <100%> (ø)`	⬆️
parser/terminal.go	`100% <100%> (ø)`	⬆️
combinator/sentence.go	`100% <100%> (ø)`
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf2287...a23865c. Read the comment docs.

bandesz added 30 commits April 2, 2018 15:15

Add file, file set and position

bfb448f

Add custom error type with position

1ec5403

Add text file and text position

b858c21

Create new Reader interface

841263c

Refactor reader to be stateless and use new file and position

96a5fa8

Make parsley.Error an interface

cb80b1c

Change error to contain Pos instead of Position

2d50d51

Make parsley.Error simple and contain only an error message

3752505

Rewrite text parsers

0583e1a

Add missing copyright notices

1ef4d7f

Update dependencies (gomea, ginkgo)

7173bc3

Delete old reader interface and reader error

4de87d0

Move parser and ast interfaces to the parsley package

a17957c

Rewrite parser packages

83ed13b

Rewrite ast packages

d8c72c0

Rewrite combinators

293229a

Rewrite Parse() and Evaluate()

99a61ac

Add proper whitespace matching

b9d493c

Simplify rune matching and string literal matching

90e5e3a

Make EmptyIntSet and EmptyIntMap constants

881f991

Replace EmptyIntMap() and EmptyIntSet() calls with constants

a85651b

Remove old test helpers

945b4e2

Add missing ginkgo suite files

0573dde

Remove token from Word terminal

f490123

Remove builder.BinaryOperation

9753440

Add Name() to parser interface, Move ParserFunc to parser.Func, creat…

09c2b0a

…ed NamedFunc struct

Change Empty() and End() parser to implement interface with Name()

01434c5

Change text parsers to implement parser interface with Name()

e2a7ca5

Also the terminals should not return with an error when there is no match.

Remove combinator.SuppressError as it's not needed anymore

c6487bf

Change combinator parsers to implement parser interface with Name()

5b73651

bandesz added 25 commits April 14, 2018 10:12

Remove unnecessary name and token parameters from the combinators

af6adbc

Allow NonTerminalNode to have no children

48cfbc0

Rename EmptyNode to NilNode, Empty parser to Nil

0e457af

Add tests for the interpreters, add generic array and object interpreter

b30735a

Use built-in array/object interpreters for the json parser, remove me…

0abedbf

…moize

Remove deprecated node builder interface and function

cae425b

Tests for the ast package + reorganise

6a2ca78

In parsley.Parse return with error only if result is empty

1dad356

Set name in text.LeftTrim and text.RightTrim parsers

b02841d

Add name back to the combinator.Seq parser

08185b4

Return error in combinator.Seq if it fails match the whole sequence

97ac4cb

Generate parser name with a function in NamedFunc as we don't always …

9806c86

…have the name when we create a parser

Allow to address EOF position in files and file sets

41619af

Add text.Trim parser to trim all whitespaces before and after

73840bd

In text.RightTrim also amend the position of an error

451a3a7

Add function to file set to translate an error with position to a use…

27568be

…ful message

Write error message with human-readable position in the json parser

217b875

Fix wrong iteration key when checking the left-rec context in History…

c24efca

….GetResult

Add tests for parser.History and parser.Func.WithName()

8fa40b0

Do not include position in error when unknown, add tests

a836c63

Delete unused template.go

72c7f0b

Fix position handling in parsley.Parse, add back tests

8d793d4

Add tests for the whitespace trim parsers

f1bd701

Don't match float values partially with the integer parser

95b51f4

Update README to reflect the latest changes

5017ae3

bandesz added 2 commits May 18, 2018 09:39

Don't allow nil childen in non-terminal node

09e8c56

Add changelog for 0.6.0

a23865c

bandesz merged commit 3efece9 into master May 18, 2018

bandesz deleted the stateless_parser branch May 18, 2018 08:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stateless parser #6

Stateless parser #6

bandesz commented May 18, 2018

codecov-io commented May 18, 2018 •

edited

Loading

Stateless parser #6

Stateless parser #6

Conversation

bandesz commented May 18, 2018

codecov-io commented May 18, 2018 • edited Loading

Codecov Report

codecov-io commented May 18, 2018 •

edited

Loading