Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI-908] made cluster id optional #1039

Merged
merged 2 commits into from
Oct 14, 2021
Merged

[CLI-908] made cluster id optional #1039

merged 2 commits into from
Oct 14, 2021

Conversation

mtodzo
Copy link
Contributor

@mtodzo mtodzo commented Oct 12, 2021

Checklist

  1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?

    • yes: ok
  2. Did you add/update any commands that accept secrets as args/flags?

    • no: ok

What

Made cluster ID an optional arg for cluster describe and it uses the active kafka from the context if no arg is passed. This is nice because if a user cluster uses an lkc, they should be able to describe it without re-entering the ID.
References


Test&Review

manually and unit tests

@mtodzo mtodzo requested a review from a team as a code owner October 12, 2021 17:35
@mtodzo mtodzo changed the title made cluster id optional [CLI-908] made cluster id optional Oct 12, 2021
@brianstrauch
Copy link
Member

Would be nice to add an integration test, too!

@mtodzo mtodzo merged commit 38dab1c into main Oct 14, 2021
@mtodzo mtodzo deleted the CLI-908-main branch October 14, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants