CLI-1287: Use external go-ps1 package for confluent prompt
#1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuweiHe
reviewed
Oct 19, 2021
| } | ||
|
|
||
| promptCmd.Flags().StringP("format", "f", `(confluent|{{color "black" "%C"}})`, "The format string to use. See the help for details.") | ||
| promptCmd.Flags().BoolP("no-color", "g", false, "Do not include ANSI color codes in the output.") |
There was a problem hiding this comment.
We no longer set the color or parse a customized timeout?
There was a problem hiding this comment.
The default format string doesn't use colors anymore, but a user can use colors if they choose by changing the format string (the --format flag).
The --timeout flag still exists (line 127)
MuweiHe
approved these changes
Oct 27, 2021
brianstrauch
changed the title
go-ps1 package for confluent promptgo-ps1 package for confluent prompt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
Did you add/update any commands that accept secrets as args/flags?
What
Use https://github.com/confluentinc/go-ps1 in place of the old internal package.