[CLI-996] remove update check during tests #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianstrauch
approved these changes
Jun 29, 2021
mtodzo
changed the title
mtodzo
changed the title
brianstrauch
pushed a commit
that referenced
this pull request
Jun 30, 2021
brianstrauch
pushed a commit
that referenced
this pull request
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?
Did you add/update any commands that accept secrets as args/flags?
What
remove update check during tests. Prior to this each integration test was making a request to s3 to check if for new CLI versions (sending this many requests may have even gotten rate-limited). Not making these requests during tests gives integration tests a big speedup -- cutting make test time at least in half (maybe a little more) from 50m to 20m on windows, and just under 40m on mac and linux to under 20m.
References
Test&Review