KGLOBAL-486: Remove "ccloud kafka topic create" --mirror-topic and --link flags, remove "ccloud kafka topic mirror" command, and rename "--link-name" to "link"

[ctan888]

Checklist

1. [CRUCIAL] Is the change for CP or CCloud functionalities that are already live in prod?

   • yes: ok
   • no: DO NOT MERGE until the required functionalites are live in prod

2. Did you add/update any commands that accept secrets as args/flags?

   • yes: did you update secretCommandFlags and/or secretCommandArgs in internal/pkg/analytics/analytics.go
   • no: ok

What

1. Removing the cluster linking commands' kapi dependency from the ccloud cli
2. Remove "ccloud kafka topic create" --mirror-topic and --link flags
3. Remove "ccloud kafka topic mirror" command
4. Rename "--link-name" to "link"

References

KGLOBAL-451 KGLOBAL-486

Test&Review

1. Unit test by mocking the API payload
2. Unit test by asserting the output (golden files)

[brianstrauch]

LGTM, although I assume there are a few tests that need to be fixed due to these deletions.

[ctan888]

@brianbushree Yes, I've regenerated the golden files. Also, I've renamed all "--link-name" flag to "--link" according to @lukeknep 's suggestion. Let me know if we are good to go.

[mtodzo]

We need to preserve backward compatibility with all CLI PRs. Changing flag names for link and mirror commands is ok since those are hidden (note that once we unhide them we don't be able to change these again without a 6 month deprecation process). Also the kafka topic mirror command is okay to remove since it has been hidden. However, we can't remove the the --mirror-topic and --link flags from topic create since those may be in use and we don't want to break existing scripts. We can remove those in CLI 2.0 release at the end of q3 since we will introduce breaking changes on the major release.

[scosta]

We can remove those in CLI 2.0 release at the end of q3 since we will introduce breaking changes on the major release.

If you haven't already, add your breaking changes to the v2.0 scheduled changes wiki to make sure this is tracked.

[mtodzo]

approved - discussed over slack that breaking change is OK since CL was only in preview