Fixed update_run.sh path and permission #84
Conversation
Wouldn't start on my Mac, probably needs the absolute path to the file
| @@ -27,8 +27,8 @@ services: | |||
| KAFKA_CONTROLLER_LISTENER_NAMES: 'CONTROLLER' | |||
| KAFKA_LOG_DIRS: '/tmp/kraft-combined-logs' | |||
| volumes: | |||
| - ./update_run.sh:/tmp/update_run.sh | |||
| command: "bash -c 'if [ ! -f /tmp/update_run.sh ]; then echo \"ERROR: Did you forget the update_run.sh file that came with this docker-compose.yml file?\" && exit 1 ; else /tmp/update_run.sh && /etc/confluent/docker/run ; fi'" | |||
| - ${PWD}/update_run.sh:/tmp/update_run.sh | |||
| - ./update_run.sh:/tmp/update_run.sh | ||
| command: "bash -c 'if [ ! -f /tmp/update_run.sh ]; then echo \"ERROR: Did you forget the update_run.sh file that came with this docker-compose.yml file?\" && exit 1 ; else /tmp/update_run.sh && /etc/confluent/docker/run ; fi'" | ||
| - ${PWD}/update_run.sh:/tmp/update_run.sh | ||
| command: "bash -c 'if [ ! -f /tmp/update_run.sh ]; then echo \"ERROR: Did you forget the update_run.sh file that came with this docker-compose.yml file?\" && exit 1 ; else chmod +x /tmp/update_run.sh && /tmp/update_run.sh && /etc/confluent/docker/run ; fi'" |
There was a problem hiding this comment.
@mbreevoort Can you please elaborate why this should be required? Shouldn't the permissions be inherited from the file, which should already be executable?
There was a problem hiding this comment.
saved the files first, my bad. After checkout the repo it works... my bad. Keep up the good work removing zookeeper :-)
There was a problem hiding this comment.
probably ${PWD} isn't needed either
There was a problem hiding this comment.
@mbreevoort that mean your PR is no more necessary ?
|
@raphaelauv PR is not needed anymore, works as designed and will close this issue and PR |
|
If somebody else will come here searching why their |
Wouldn't start on my Mac, probably needs the absolute path to the file
Description
Fixed path to update_run.sh (couldn't mount the relative path)
Permissions fix when run the script
Author Validation
After this fix
docker-compose upstarts correct.Reviewer Tasks
Test if
docker-compose upstill starts