-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace docker-compose exec with docker exec #418
Conversation
Running locally with docker compose v 1.29. Will update. Update: CP Demo successfully started |
Thanks for the PR, that saved my day. I ran into issues after updating cp-demo on MacOS with most recent versions of docker and compose available. CP successfully up and running on my system:
|
@Schm1tz1 btw, the latest version of docker-compose is 2.4, not 1.29. It's a whole thing. It's what ended up breaking cp demo. We should get this PR merged soon and it will work on both 2.4 and 1.29. |
@chuck-confluent you are absolutely correct. The problem is, you only get that version if you install it e.g. with homebrew or pip. Compose 1.29 still comes bundled with docker-desktop and that will affect many users like me before manually installing the newer compose. |
@Schm1tz1 I think the next docker for desktop update will update compose to 2.4. I'm already seeing folks on mac like this person: docker/compose#9202 (comment) oh but it looks like the breaking behavior might only be in V2.2…hmmm. Well anyway, this PR will help everyone :-) |
Description
https://confluentinc.atlassian.net/browse/TMM-76
What behavior does this PR change, and why?
There is a breaking change in the TTY output behavior of
docker-compose exec
between docker compose v1 and v2:Since we explicitly set
container_name
indocker-compose.yml
,docker exec
works the same asdocker-compose exec
, except by not usingdocker-compose
, we avoid the discrepancy between dc v1 and v2.Author Validation
Describe the validation already done, or needs to be done, by the PR submitter.
Reviewer Tasks
Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.