Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace docker-compose exec with docker exec #418

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Conversation

chuck-confluent
Copy link
Contributor

@chuck-confluent chuck-confluent commented Apr 7, 2022

Description

https://confluentinc.atlassian.net/browse/TMM-76

What behavior does this PR change, and why?

There is a breaking change in the TTY output behavior of docker-compose exec between docker compose v1 and v2:

Since we explicitly set container_name in docker-compose.yml, docker exec works the same as docker-compose exec, except by not using docker-compose, we avoid the discrepancy between dc v1 and v2.

Author Validation

Describe the validation already done, or needs to be done, by the PR submitter.

Reviewer Tasks

Describe the tasks/validation that the PR submitter is requesting to be done by the reviewer.

@gitpod-io
Copy link

gitpod-io bot commented Apr 7, 2022

@chuck-confluent chuck-confluent marked this pull request as draft April 7, 2022 22:22
@chuck-confluent
Copy link
Contributor Author

chuck-confluent commented Apr 7, 2022

Running locally with docker compose v 1.29. Will update.

Update: CP Demo successfully started

@chuck-confluent chuck-confluent removed the request for review from ybyzek April 7, 2022 22:34
@chuck-confluent chuck-confluent marked this pull request as ready for review April 7, 2022 22:41
@chuck-confluent chuck-confluent requested review from jwfbean and removed request for ybyzek April 7, 2022 23:37
@Schm1tz1
Copy link
Member

Schm1tz1 commented Apr 8, 2022

Thanks for the PR, that saved my day. I ran into issues after updating cp-demo on MacOS with most recent versions of docker and compose available.

CP successfully up and running on my system:

  • MacOS 12.3.1
  • docker-compose version 1.29.2
  • Docker engine version 20.10.14

@chuck-confluent
Copy link
Contributor Author

@Schm1tz1 btw, the latest version of docker-compose is 2.4, not 1.29. It's a whole thing. It's what ended up breaking cp demo. We should get this PR merged soon and it will work on both 2.4 and 1.29.

@Schm1tz1
Copy link
Member

Schm1tz1 commented Apr 8, 2022

@chuck-confluent you are absolutely correct. The problem is, you only get that version if you install it e.g. with homebrew or pip. Compose 1.29 still comes bundled with docker-desktop and that will affect many users like me before manually installing the newer compose.

@chuck-confluent
Copy link
Contributor Author

chuck-confluent commented Apr 8, 2022

@Schm1tz1 I think the next docker for desktop update will update compose to 2.4. I'm already seeing folks on mac like this person: docker/compose#9202 (comment)

oh but it looks like the breaking behavior might only be in V2.2…hmmm. Well anyway, this PR will help everyone :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants