-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KSQL Server Docker healthcheck #22
Conversation
I've taken @rodesai's feedback and used a variable to store the response. I've also amended the script to use the REST endpoint for status probe. This is because the KSQL server New testing when Kafka is unavailable shows the healthcheck then picks this up :
|
Since @rodesai is on PTO now, could someone else on @confluentinc/ksql take a look at this please? ta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Upgraded netty version to 4.8.112.Final
Testing done : added healthcheck to a local build of the image, tested it successfully:
Docker shows the container as
healthy
: