Speed up and fix flaky integration test #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved! Please merge. |
VedarthConfluent
added a commit
that referenced
this pull request
Aug 8, 2024
* [KSQL-12378] | Vedarth Sharma | Update classgraph to 4.8.174 (#19) * Switch to older classgraph version (#20) * [KSQL-12378] | Vedarth Sharma | Update classgraph to 4.8.174 * [KSQL-12378] | Vedarth Sharma | Switch to older classgraph version * Ignore test in 7.1.x (#23) * [KSQL-12378] | Vedarth Sharma | Update classgraph to 4.8.174 * [KSQL-12378] | Vedarth Sharma | Switch to older classgraph version * [KSQL-12378] | Vedarth Sharma | Ignore test * [KSQL-12378] | Vedarth Sharma | Ignore single test * Add a comment (#30) * [KSQL-12378] | Vedarth Sharma | Update classgraph to 4.8.174 * [KSQL-12378] | Vedarth Sharma | Switch to older classgraph version * [KSQL-12378] | Vedarth Sharma | Ignore test * [KSQL-12378] | Vedarth Sharma | Ignore single test * [KSQL-12378] | Vedarth Sharma | Add a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no check to make sure that the produced records for the aggregate test were actually within the window specified, and the test failed a few times on my machine as a result. This change should address that, by guaranteeing that expected records are only actually expected if they were produced within the same window.
Also, calls to
Thread.sleep()were removed, as they appeared to be unnecessary and only increase runtime.