refactor: implement ExpressionVisitor in SqlToJava #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodesai
force-pushed
the
sql-to-java-visitor-only-expressions
branch
2 times, most recently
from
7f93e1c
to
cdaf956
Compare
agavra
approved these changes
Jul 26, 2019
ksql-engine/src/main/java/io/confluent/ksql/codegen/SqlToJavaVisitor.java
Outdated
Show resolved
Hide resolved
ksql-engine/src/main/java/io/confluent/ksql/codegen/SqlToJavaVisitor.java
Outdated
Show resolved
Hide resolved
SqlToJavaVisitor only needs to deal with expressions, so this patch has it implementExpressionVisitor. This patch also adds some missing test cases to its unit test for handling unsupported type constructors. Finally, we simplify the tests a bit by having them just parse expressions (instead of whole statements).
rodesai
force-pushed
the
sql-to-java-visitor-only-expressions
branch
from
e671b4a
to
8f29b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SqlToJavaVisitor only needs to deal with expressions, so this patch has
it implementExpressionVisitor. This patch also adds some missing test
cases to its unit test for handling unsupported type constructors.
Finally, we simplify the tests a bit by having them just parse expressions
(instead of whole statements).
This patch depends on #3126, so review that first.