refactor: rename TopicAccessValidator to KsqlAuthorizationValidator #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
spena
changed the title
...ngine/src/test/java/io/confluent/ksql/security/DefaultStatementPermissionsValidatorTest.java
Outdated
Show resolved
Hide resolved
spena
force-pushed
the
rename_topic_access_validator
branch
from
4a7a639
to
e4fb956
Compare
The new class name will be used to validate topic and SR schema authorization. Also, it moves the class to the ksq-engine/.../security directory.
spena
force-pushed
the
rename_topic_access_validator
branch
from
e4fb956
to
78fbc69
Compare
spena
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the
TopicAccessValidatortoKsqlAuthorizationValidator(including subclases and tests).This will be used for SchemaRegistry permisisons checks in a follow-up PR, so the new name makes more sense which will check authorization for topics and schemas.
More refactoring is done here by moving the classes to the
ksql-engine/.../securitydirectory.PR #3261 depends from this class.
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist