Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not allow WITH clause to be created with invalid WINDOW_SIZE #3432

Merged
merged 1 commit into from
Sep 27, 2019
Merged

fix: do not allow WITH clause to be created with invalid WINDOW_SIZE #3432

merged 1 commit into from
Sep 27, 2019

Conversation

big-andy-coates
Copy link
Contributor

Description

Previously the code would fail when the window size was being accessed. This PR makes it fail when the properties are being constructed, leading to a better error message, earlier.

Testing done

tests added.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@big-andy-coates big-andy-coates requested a review from a team as a code owner September 27, 2019 13:42
agavra
agavra approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@agavra agavra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm

@big-andy-coates big-andy-coates merged commit 96bfc11 into confluentinc:master Sep 27, 2019
@big-andy-coates big-andy-coates deleted the window_size branch September 27, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agavra agavra agavra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-andy-coates @agavra