chore: partition-by primitive key support #4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First of a few commits to start introducing support for primitive keys in different query types. This commit opens the door for CT/CS statements with primitive keys, (`STRING`, `INT`, `BIGINT`, `BOOLEAN` and `DOUBLE`), and for using those sources in non-join, non-aggregate and non-partition-by queries.
Fixes: confluentinc#4092 WIP: This commit gets `PARTITION BY` clauses working with primitive key types. However, it does disable a couple of join until confluentinc#4094 has been completed. BREAKING CHANGE: A `PARTITION BY` now changes the SQL type of `ROWKEY` in the output schema of a query. For example, consider: ```sql CREATE STREAM INPUT (ROWKEY STRING KEY, ID INT) WITH (...); CREATE STREAM OUTPUT AS SELECT ROWKEY AS NAME FROM INPUT PARTITION BY ID; ``` Previously, the above would have resulted in an output schema of `ROWKEY STRING KEY, NAME STRING`, where `ROWKEY` would have stored the string representation of the integer from the `ID` column. With this commit the output schema will be `ROWKEY INT KEY, NAME STRING`.
rodesai
reviewed
Dec 11, 2019
| final LogicalSchema sourceSchema, | ||
| final StreamSelectKey step | ||
| ) { | ||
| final ExpressionTypeManager expressionTypeManager = |
There was a problem hiding this comment.
Can we move this out of this class? Ideally this class should just be routing to something else that owns the schema transformation. We can move it to the step builder for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: This was stacked on top of #4096
Fixes: #4092
WIP: This commit gets
PARTITION BYclauses working with primitive key types. However, it does disable a couple of join until #4094 has been completed.BREAKING CHANGE: A
PARTITION BYnow changes the SQL type ofROWKEYin the output schema of a query.For example, consider:
Previously, the above would have resulted in an output schema of
ROWKEY STRING KEY, NAME STRING, whereROWKEYwould have stored the string representation of the integer from theIDcolumn. With this commit the output schema will beROWKEY INT KEY, NAME STRING.Testing done
Suitable QTT tests added / updated.
Reviewer checklist