feat: add PARSE_DATE and FORMAT_DATE functions #7733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimGalasyn
reviewed
Jun 28, 2021
JimGalasyn
reviewed
Jun 28, 2021
JimGalasyn
reviewed
Jun 28, 2021
JimGalasyn
approved these changes
Jun 28, 2021
spena
reviewed
Jun 28, 2021
| } | ||
| try { | ||
| final DateTimeFormatter formatter = formatters.get(formatPattern); | ||
| return LocalDate.ofEpochDay(TimeUnit.MILLISECONDS.toDays(date.getTime())).format(formatter); |
There was a problem hiding this comment.
I wonder what if formatPattern contains time characters? Would those be part of the final String?
There was a problem hiding this comment.
Added a test for this.
| final Object result = udf.formatDate(Date.valueOf("2014-11-09"), "yyyy-dd-MM'Fred'"); | ||
|
|
||
| // Then: | ||
| assertThat(result, is("2014-09-11Fred")); |
There was a problem hiding this comment.
I'm not sure about this. Should we support embedded chars in the final date string?
There was a problem hiding this comment.
It was supported in the old DateToString function:
There was a problem hiding this comment.
Just tested Mysql and it supports this too. Perhaps it is allowed in order to write the format you want, i.e. dates yyyy/MM/dd or yyyy-MM-dd or Today is Year = yyyy Month = MM Day = dd
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables DATE data for UDFs and adds the PARSE_DATE and FORMAT_DATE functions + docs.
Testing done
QTT + unit tests
Reviewer checklist